1749425 - Add "X" close button on first/introduction pane for all UI variations

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Daisuke Akatsuka (:daisuke)]

In the discussion on slack, we add "X" close button on first/introduction pane for all UI variations.

Comment 1

[Daisuke Akatsuka (:daisuke)]

[Tracking Requested - why for this release]:
This is necessary for the next Firefox Suggest rollout in 96.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1749425: Add X close button on introduction page for all UI variations.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16bf45a220d8
Add X close button on introduction page for all UI variations. r=adw

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/16bf45a220d8

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9258426 [details]
Bug 1749425: Add X close button on introduction page for all UI variations.

Beta/Release Uplift Approval Request

• User impact if declined: This is necessary for the next Firefox Suggest rollout in a 96 dot release.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Every treatment should have an X close button in the first screen now, as discussed
• List of other uplifts needed: On 96, bug 1745026 must be uplifted first
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only adds a close button to the Firefox Suggest opt-in modal, which will only be shown in an experiment. Has tests and QA coverage.
• String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9258426 [details]
Bug 1749425: Add X close button on introduction page for all UI variations.

Approved for 97.0b2.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c8b5204cf6e

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

• We have verified this issue using the latest Nightly 98.0a1 build (Build ID: 20220111093827) and the latest Beta 97.0b2 (Build ID: 20220111185943) build, on Windows 10 x64, macOS 10.15.7, and Linux Ubuntu 20.04 x64.
• The "X" button is displayed on all opt-in modals of each treatment branch.
• The accept and dismiss events are correctly registered for each scenario.
• The "browser.urlbar.quicksuggest.onboardingDialogChoice" pref is correctly set for each accept and dismiss scenario.

While verifying this we have encountered the following two issues with the "X" button: Bug 1749740 and Bug 1749741.

I will leave the "qe-verify" flag set, to re-verify this issue after it will be uplifted in Firefox 96 dot release.

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9258426 [details]
Bug 1749425: Add X close button on introduction page for all UI variations.

Approved for 96.0.2

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/de0750426f67

Comment 11

[Cosmin Muntean [:cmuntean], Ecosystem QA]

We have verified this issue on the latest 96.0.2 build (Build ID: 20220119040736) on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04 x64.

• The "X" button is displayed on all opt-in modals of each treatment branch.
• The accept and dismiss events are correctly registered for each scenario.
• The "browser.urlbar.quicksuggest.onboardingDialogChoice" pref is correctly set for each accept and dismiss scenario.