Closed Bug 1749425 Opened 4 months ago Closed 4 months ago

Add "X" close button on first/introduction pane for all UI variations

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

VERIFIED FIXED
98 Branch
Tracking Status
firefox96 + verified
firefox97 + verified
firefox98 --- verified

People

(Reporter: daisuke, Assigned: daisuke)

References

Details

Attachments

(1 file)

In the discussion on slack, we add "X" close button on first/introduction pane for all UI variations.

[Tracking Requested - why for this release]:
This is necessary for the next Firefox Suggest rollout in 96.

Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16bf45a220d8
Add X close button on introduction page for all UI variations. r=adw
Flags: qe-verify+
Flags: in-testsuite+
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch

Comment on attachment 9258426 [details]
Bug 1749425: Add X close button on introduction page for all UI variations.

Beta/Release Uplift Approval Request

  • User impact if declined: This is necessary for the next Firefox Suggest rollout in a 96 dot release.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Every treatment should have an X close button in the first screen now, as discussed
  • List of other uplifts needed: On 96, bug 1745026 must be uplifted first
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This only adds a close button to the Firefox Suggest opt-in modal, which will only be shown in an experiment. Has tests and QA coverage.
  • String changes made/needed:
Attachment #9258426 - Flags: approval-mozilla-release?
Attachment #9258426 - Flags: approval-mozilla-beta?

Comment on attachment 9258426 [details]
Bug 1749425: Add X close button on introduction page for all UI variations.

Approved for 97.0b2.

Attachment #9258426 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]
  • We have verified this issue using the latest Nightly 98.0a1 build (Build ID: 20220111093827) and the latest Beta 97.0b2 (Build ID: 20220111185943) build, on Windows 10 x64, macOS 10.15.7, and Linux Ubuntu 20.04 x64.
  • The "X" button is displayed on all opt-in modals of each treatment branch.
  • The accept and dismiss events are correctly registered for each scenario.
  • The "browser.urlbar.quicksuggest.onboardingDialogChoice" pref is correctly set for each accept and dismiss scenario.

While verifying this we have encountered the following two issues with the "X" button: Bug 1749740 and Bug 1749741.

I will leave the "qe-verify" flag set, to re-verify this issue after it will be uplifted in Firefox 96 dot release.

Status: RESOLVED → VERIFIED

Comment on attachment 9258426 [details]
Bug 1749425: Add X close button on introduction page for all UI variations.

Approved for 96.0.2

Attachment #9258426 - Flags: approval-mozilla-release? → approval-mozilla-release+

We have verified this issue on the latest 96.0.2 build (Build ID: 20220119040736) on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04 x64.

  • The "X" button is displayed on all opt-in modals of each treatment branch.
  • The accept and dismiss events are correctly registered for each scenario.
  • The "browser.urlbar.quicksuggest.onboardingDialogChoice" pref is correctly set for each accept and dismiss scenario.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.