1749531 - Use non-native themed scrollbars in browser chrome

Status: RESOLVED FIXED

(Core :: Widget, enhancement)

Description

[Shane Hughes [:aminomancer]]

In bug 1719427 support was added for switching between non-native scrollbar styles with a pref, but these styles aren't yet applied to scrollbars in the browser chrome or dialogs, which will continue to use the platform style.

STR:

1. Set widget.non-native-theme.scrollbar.style to a number that doesn't match your environment (1 for macOS, 2 for GTK, 3 for android, 4 for win 10, 5 for win 11)
2. View a page in a browser and confirm the scrollbar style has changed.
3. Open some scrollable chrome control, e.g., the all tabs menu, the bookmarks sidebar or the page info dialog.

Expected:
The chrome scrollbars match the content scrollbars

Actual:
The chrome scrollbars continue to use default platform style

Comment 1

[Emilio Cobos Álvarez [:emilio]]

So this is kind of expected, fwiw. But anyhow, if we want to change this fix should be straight-forward. Changing this and the relevant GTK line to use ScrollbarStyle(), and maybe make it react to the pref dynamically.

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1749531 - Use non-native themed scrollbars in browser chrome r?emilio

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Looking into this a bit more we can make it work more consistently pretty easily, let me try...

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Will most likely not get to it today though I don't think this is super-urgent.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

This is not fixed?

Comment 6

[Shane Hughes [:aminomancer]]

Isn't it? Seems to be working in the views I was worried about

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1749531 - Manage native theme lifetime from Theme.cpp. r=spohl,mstange

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1749531 - Move RecomputeScrollbarParams call to SetScrollbarDrawing. r=spohl,mstange

Depends on D136127

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1749531 - Remove scrollbar drawing code from nsNativeThemeCocoa, use ThemeCocoa drawing. r=spohl,mstange

Depends on D136128

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1749531 - Allow to override native theme scrollbar styles. r=spohl,mstange

Depends on D136129

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d1e386d334b
Manage native theme lifetime from Theme.cpp. r=mstange
https://hg.mozilla.org/integration/autoland/rev/1fa55e27c971
Move RecomputeScrollbarParams call to SetScrollbarDrawing. r=mstange
https://hg.mozilla.org/integration/autoland/rev/4b4804252e15
Remove scrollbar drawing code from nsNativeThemeCocoa, use ThemeCocoa drawing. r=mstange
https://hg.mozilla.org/integration/autoland/rev/7049c6e86a3e
Allow to override native theme scrollbar styles. r=mstange

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6d1e386d334b
https://hg.mozilla.org/mozilla-central/rev/1fa55e27c971
https://hg.mozilla.org/mozilla-central/rev/4b4804252e15
https://hg.mozilla.org/mozilla-central/rev/7049c6e86a3e