1749555 - Remove unnecessary printf_stderr

Status: RESOLVED FIXED

(Core :: DLL Services, defect, P3)

Description

[Toshihito Kikuchi [:toshi]]

I mistakenly added printf_stderr that was for debugging to UntrustedModulesProcessor.cpp in the patch of bug 1746114.

Comment 1

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1749555 - Remove unnecessary printf_stderr in UntrustedModulesProcessor.cpp. r=mhowell

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72b232cb8f5d
Remove unnecessary printf_stderr in UntrustedModulesProcessor.cpp.  r=mhowell

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/72b232cb8f5d

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1746114

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:toshi, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Toshihito Kikuchi [:toshi]]

Comment on attachment 9258512 [details]
Bug 1749555 - Remove unnecessary printf_stderr in UntrustedModulesProcessor.cpp. r=mhowell

Beta/Release Uplift Approval Request

• User impact if declined: This change is not visible to users, but having an unnecessary function call and calling it every time a module is loaded has bad performance impact.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is to remove a function call to printf_stderr that was mistakenly included in the previous patch (bug 1746114). The regression risk is nearly zero.
• String changes made/needed: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9258512 [details]
Bug 1749555 - Remove unnecessary printf_stderr in UntrustedModulesProcessor.cpp. r=mhowell

Approved for 97.0b4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2a5a8426fc61