Closed Bug 1749666 Opened 1 year ago Closed 9 months ago

Wait for TabSelect properly when switching tabs

Categories

(Testing :: Marionette, enhancement, P2)

Default
enhancement
Points:
2

Tracking

(firefox102 fixed)

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: whimboo, Assigned: jdescottes, Mentored)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [bidi-m3-mvp])

Attachments

(2 files)

Since bug 1745267 has been landed for Firefox 97 there is the new event TabSwitched available on the tabbrowser. This is more reliable as TabSelect which returns earlier - means before the tab switch actually happened.

We should update browser.js to make use of it.

Priority: -- → P3
Assignee: nobody → hskupin
Status: NEW → ASSIGNED

Voting to add this bug to M3 with 2 points because it enhances the reliability when switching tabs. Julian, do you agree with the points?

Flags: needinfo?(jdescottes)
Whiteboard: [lang=js] → [bidi-m3-mvp]
Priority: P3 → P2

2 points is fine. It's a bit big for 2 points but probably not big enough for 8 points.

Flags: needinfo?(jdescottes)
Points: --- → 2
Blocks: 1704394

The patch series on bug 1759559 will introduce some changes to the TabManager module which conflicts with mine. As such I'll wait for the other bug to get landed first.

Depends on: 1759559

Discussed with Henrik, will pick up the remaining work here.

Assignee: hskupin → jdescottes
Blocks: 1767314

Repurposing this bug in order to wait properly for TabSelect, we will look at replacing it with TabSwitched in the followup bug 1767314

Summary: Consider using TabSwitched event instead of TabSelect → Wait for TabSelect properly when switching tabs
Attachment #9264449 - Attachment description: Bug 1749666 - [remote] Use TabSwitched event instead of TabSelect when switching tabs. → Bug 1749666 - [remote] Wait for TabSelect when switching tabs.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2dafed9b791
[marionette] Remove usage of waitForEvent in favor of EventPromise. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/9252d89f8b17
[remote] Wait for TabSelect when switching tabs. r=webdriver-reviewers,whimboo
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Blocks: 1533058
You need to log in before you can comment on or make changes to this bug.