Wait for TabSelect properly when switching tabs
Categories
(Remote Protocol :: Marionette, enhancement, P2)
Tracking
(firefox102 fixed)
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: whimboo, Assigned: jdescottes, Mentored)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [bidi-m3-mvp])
Attachments
(2 files)
Since bug 1745267 has been landed for Firefox 97 there is the new event TabSwitched available on the tabbrowser. This is more reliable as TabSelect which returns earlier - means before the tab switch actually happened.
We should update browser.js to make use of it.
|
Reporter | |
Updated•2 years ago
|
|
|
Reporter | |
Comment 1•2 years ago
|
||
Depends on D139058
|
||
Updated•2 years ago
|
|
|
Reporter | |
Comment 2•2 years ago
|
||
Depends on D139059
|
|
Reporter | |
Comment 3•2 years ago
|
||
Voting to add this bug to M3 with 2 points because it enhances the reliability when switching tabs. Julian, do you agree with the points?
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 4•2 years ago
|
||
2 points is fine. It's a bit big for 2 points but probably not big enough for 8 points.
|
|
Reporter | |
Updated•2 years ago
|
|
|
Reporter | |
Comment 5•2 years ago
|
||
The patch series on bug 1759559 will introduce some changes to the TabManager module which conflicts with mine. As such I'll wait for the other bug to get landed first.
|
|
Assignee | |
Comment 6•2 years ago
|
||
Discussed with Henrik, will pick up the remaining work here.
|
|
Assignee | |
Comment 7•2 years ago
|
||
Repurposing this bug in order to wait properly for TabSelect, we will look at replacing it with TabSwitched in the followup bug 1767314
|
|
||
Updated•2 years ago
|
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2dafed9b791 [marionette] Remove usage of waitForEvent in favor of EventPromise. r=webdriver-reviewers,jdescottes https://hg.mozilla.org/integration/autoland/rev/9252d89f8b17 [remote] Wait for TabSelect when switching tabs. r=webdriver-reviewers,whimboo
|
||
Comment 9•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a2dafed9b791
https://hg.mozilla.org/mozilla-central/rev/9252d89f8b17
|
||
Updated•1 year ago
|
Description
•