1749666 - Wait for TabSelect properly when switching tabs

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Since bug 1745267 has been landed for Firefox 97 there is the new event TabSwitched available on the tabbrowser. This is more reliable as TabSelect which returns earlier - means before the tab switch actually happened.

We should update browser.js to make use of it.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1749666 - [marionette] Remove usage of waitForEvent in favor of EventPromise.

Depends on D139058

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1749666 - [remote] Wait for TabSelect when switching tabs.

Depends on D139059

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Voting to add this bug to M3 with 2 points because it enhances the reliability when switching tabs. Julian, do you agree with the points?

Comment 4

[Julian Descottes [:jdescottes]]

2 points is fine. It's a bit big for 2 points but probably not big enough for 8 points.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The patch series on bug 1759559 will introduce some changes to the TabManager module which conflicts with mine. As such I'll wait for the other bug to get landed first.

Comment 6

[Julian Descottes [:jdescottes]]

Discussed with Henrik, will pick up the remaining work here.

Comment 7

[Julian Descottes [:jdescottes]]

Repurposing this bug in order to wait properly for TabSelect, we will look at replacing it with TabSwitched in the followup bug 1767314

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2dafed9b791
[marionette] Remove usage of waitForEvent in favor of EventPromise. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/9252d89f8b17
[remote] Wait for TabSelect when switching tabs. r=webdriver-reviewers,whimboo

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a2dafed9b791
https://hg.mozilla.org/mozilla-central/rev/9252d89f8b17