1749697 - Window screen sharing broken in Hubs

Status: RESOLVED WORKSFORME

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Manuel Martin]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:98.0) Gecko/20100101 Firefox/98.0

Steps to reproduce:

• Go to https://hubs.mozilla.com and create a room
• Share your screen using the bottom toolbar button "Share"
• Choose a window (not the entire screen)

Actual results:

The shared window is rendered as a plain dark colored texture.

Expected results:

You should see the window being shared rendered in a texture.

In the console you can see the following warning:
WebGL warning: texImage: Fast Tex(Sub)Image upload failed without recourse, clearing to [0.2, 0.0, 0.2, 1.0]. Please file a bug! 32
After reporting 32, no further warnings will be reported for this WebGL context.

This seems to be caused by this patch:
https://github.com/mozilla/hubs/blob/0ba60ee8ac610eb6236e4ac5e5a88da8f1b748ef/src/components/media-video.js#L530-L538
which is related to this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1680851 that has not been fixed yet. Uncommenting that line fixes the use but then we incur in a notable frame drop.

This is working correctly in FF 95.

Mozregression output:
16:37.22 INFO: Using local file: /var/folders/0s/gngl1zqd3r77lh7m7fpk6jc40000gn/T/tmpy3osiq6c/a87211c8eedd-shippable--autoland--target.dmg (downloaded in background)
16:37.22 INFO: Running autoland build built on 2021-12-16 20:57:57.406000, revision a87211c8
17:04.53 INFO: Launching /private/var/folders/0s/gngl1zqd3r77lh7m7fpk6jc40000gn/T/tmp2wq4uc3q/Firefox Nightly.app/Contents/MacOS/firefox
17:04.53 INFO: Application command: /private/var/folders/0s/gngl1zqd3r77lh7m7fpk6jc40000gn/T/tmp2wq4uc3q/Firefox Nightly.app/Contents/MacOS/firefox -foreground -profile /var/folders/0s/gngl1zqd3r77lh7m7fpk6jc40000gn/T/tmpgxmhd6ar.mozrunner
17:04.55 INFO: application_buildid: 20211215015132
17:04.55 INFO: application_changeset: a87211c8eedde447aec9e270172948f51b8b510e
17:04.55 INFO: application_name: Firefox
17:04.55 INFO: application_repository: https://hg.mozilla.org/integration/autoland
17:04.55 INFO: application_version: 97.0a1
Was this integration build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', 'back' or 'exit' and press Enter): good
17:41.32 INFO: Narrowed integration regression window from [26662231, 3d201ea8] (3 builds) to [a87211c8, 3d201ea8] (2 builds) (~1 steps left)
17:41.32 INFO: No more integration revisions, bisection finished.
17:41.32 INFO: Last good revision: a87211c8eedde447aec9e270172948f51b8b510e
17:41.32 INFO: First bad revision: 3d201ea8834161911890a06bae578b64d18eefa9
17:41.32 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a87211c8eedde447aec9e270172948f51b8b510e&tochange=3d201ea8834161911890a06bae578b64d18eefa9

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1746111

Comment 3

[Kelsey Gilbert [:jgilbert]]

Please attach an about:support.

Comment 4

[Manuel Martin]

Attachment: Application Basics ------------------ Name: Firefox Version: 98.0a1 Build ID: 20220114093102 Distribution ID: Update Channel: nightly User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:98.0) Gecko/20100101 Firefox/98.0 OS: Darwin 21.2.0 Darwin

Comment 5

[Kelsey Gilbert [:jgilbert]]

Do you have an about:support from a run where you repro'd this problem? I'm looking for this line in the notes: https://searchfox.org/mozilla-central/source/dom/canvas/TexUnpackBlob.cpp#790

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Too late to address in 97 with next week's RC coming up. Hopefully we can make progress on this for 98 still.

Comment 7

[Manuel Martin]

Attachment: Application Basics ------------------ Name: Firefox Version: 98.0a1 Build ID: 20220130190959 Distribution ID: Update Channel: nightly User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:98.0) Gecko/20100101 Firefox/98.0 OS: Darwin 21.2.0 Darwin

Comment 8

[Manuel Martin]

Sorry for the delay, there it's the about:support I can see the log line there.

Comment 9

[Kelsey Gilbert [:jgilbert]]

Oh that's perfect, thank you!

Failure Log
(#0) Assert: GuessDivisors failed:1233,675, 617,338
(#1083) Error: BlitSdToFramebuffer failed for type 1
(#1084) Assert: GuessDivisors failed:1207,688, 604,344
(#1085) Error: BlitSdToFramebuffer failed for type 1
(#1086) Assert: GuessDivisors failed:1207,688, 604,344
(#1087) Error: BlitSdToFramebuffer failed for type 1
(#1088) Assert: GuessDivisors failed:1207,688, 604,344
(#1089) Error: BlitSdToFramebuffer failed for type 1
(#1090) Assert: GuessDivisors failed:1207,688, 604,344
(#1091) Error: BlitSdToFramebuffer failed for type 1
(#1092) Assert: GuessDivisors failed:1207,688, 604,344
(#1093) Error: BlitSdToFramebuffer failed for type 1
(#1094) Assert: GuessDivisors failed:1207,688, 604,344
(#1095) Error: BlitSdToFramebuffer failed for type 1
(#1096) Assert: GuessDivisors failed:1207,688, 604,344
(#1097) Error: BlitSdToFramebuffer failed for type 1

Interesting, not what I though, and definitely a lead!

Comment 10

[Bob Hood [:bhood]]

Kelsey, can I get an update on this?

Comment 11

[Kelsey Gilbert [:jgilbert]]

We need to jump back into this.

Comment 12

[Kelsey Gilbert [:jgilbert]]

I'm getting this now in console:

DOMException: The object can not be found here. console.js:35:31
    t console.js:35
    s scene-entry-manager.js:349
    startVideoShare media-devices-manager.js:428
    ws hub-a8529f3c57011cc98a0a.js:1
    s hub-a8529f3c57011cc98a0a.js:1
    (Async: promise callback)
    ws hub-a8529f3c57011cc98a0a.js:1
    o hub-a8529f3c57011cc98a0a.js:1
    _s hub-a8529f3c57011cc98a0a.js:1
    _s hub-a8529f3c57011cc98a0a.js:1
    startVideoShare media-devices-manager.js:386
    _setupMedia scene-entry-manager.js:389
    a raven.js:377
    value Aframe
    p SharePopoverContainer.js:96
    onClick ButtonGridPopover.js:19
    React 12
    unstable_runWithPriority scheduler.production.min.js:19
    React 3
    a raven.js:377

What should I do?

Comment 13

[Manuel Martin]

I can't get error that following the original STRs. Could you share your steps?

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 15

[Manuel Martin]

This seems to be fixed now so it can be closed.