Open
Bug 1749858
Opened 3 years ago
Updated 3 years ago
mfbt/Result should have better ergonomics (like Maybe)
Categories
(Core :: MFBT, task)
Core
MFBT
Tracking
()
NEW
People
(Reporter: jgilbert, Unassigned)
Details
What I have to write:
const auto unpackRes = ExplicitUnpacking(pi);
if (!unpackRes.isOk()) {
Warn(unpackRes.inspectErr());
return;
}
const auto& unpack = unpackRes.inspect();
if (cpuData) {
if (!size.x || !size.y || !size.z) return;
const auto bytesUpperBound = CheckedInt<size_t>(unpack.metrics.bytesPerRowStride)
* unpack.metrics.totalRows;
What I want to write:
const auto unpack = ExplicitUnpacking(pi);
if (!unpack) {
Warn(unpack.err());
return;
}
if (cpuData) {
if (!size.x || !size.y || !size.z) return;
const auto bytesUpperBound = CheckedInt<size_t>(unpack->metrics.bytesPerRowStride)
* unpack->metrics.totalRows;
You need to log in
before you can comment on or make changes to this bug.
Description
•