174987 - Rewrap deletes signature

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Karsten Düsterloh]

Mozilla 1.2b [
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021016], mail
composition is in text mode, graphical quote bar is turned off.


Rewrapping mails with quoted text deletes the signature:

Steps to reproduce:
(a) - compose new mail or posting
    - start line with >
    - rewrap
    => signature deleted
(b) - reply to mail or posting
    - rewrap
    => signature deleted

BTW: the graphical quote bar is also visible even though disabled :(

Comment 1

[Boris 'pi' Piwinger]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20021002

I can see it with Linux. No 1.2b available for testing because bug 1.2b was
treated as WONTFIX, which is also the reason for you last remark.

Akkana, I guess the idea is that when rewrapping you do not want to destroy the
signature and hence remove it. We just need to include it again after rewrapping.

Maybe the better way would be to include the signature upon sending, not when
composing as now.

pi

Comment 2

[Akkana Peck]

Aha: in some cases it was throwing away the final chunk.  Also, I noticed that
the rewrap wasn't undoable as a single chunk, so I fixed that too.  Simple fix,
which I I can get approval to get in for 1.2final.

Comment 3

[Akkana Peck]

Attachment: Fix: don't end the loop prematurely

Here's the fix.  Seeking review.

Comment 4

[kinmoz]

Comment on attachment 103210 [details] [diff] [review]
Fix: don't end the loop prematurely

sr=[e-mail]

Comment 5

[Kathleen :Brade]

Comment on attachment 103210 [details] [diff] [review]
Fix: don't end the loop prematurely

r=brade

Comment 6

[Akkana Peck]

*** Bug 174721 has been marked as a duplicate of this bug. ***

Comment 7

[Akkana Peck]

*** Bug 174601 has been marked as a duplicate of this bug. ***

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 103210 [details] [diff] [review]
Fix: don't end the loop prematurely

a=asa for checkin to 1.2 (on behalf of drivers).

Comment 9

[Boris 'pi' Piwinger]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/2002101815 (+ patches
101274, 101762, 103210)

Patch WFM, but it adds a newline to the signature if it does not end in one.

pi

Comment 10

[Akkana Peck]

Fixed.

Comment 11

[Matthias Versen [:Matti]]

*** Bug 175805 has been marked as a duplicate of this bug. ***

Comment 12

[Pete Flugstad]

*** Bug 177170 has been marked as a duplicate of this bug. ***

Comment 13

[esther]

Verified when verifying bug 173953, this was mentioned in that bug.