1749935 - Clean up nsParser

Status: RESOLVED FIXED

(Core :: XML, enhancement)

Description

[Peter Van der Beken [:peterv]]

There's quite a bit of unused code in nsParser. I have patches to clean it up a bit.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Mark nsIParser::WillResume(Impl) as infallible. r?hsivonen!

Depends on D135835

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove unused PREFER_LATTER_ERROR_CODE. r?hsivonen!

Depends on D135836

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove unused eAutoDetectResult values. r?hsivonen!

Depends on D135837

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove nsIParser::GetChannel. r?hsivonen!

Depends on D135838

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove nsIParser::MarkAsNotScriptCreated. r?hsivonen!

Depends on D135839

Comment 6

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove unused nsParser::SetUnusedInput. r?hsivonen!

Depends on D135840

Comment 7

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove unused NS_PARSER_FLAG_OBSERVERS_ENABLED and NS_PARSER_FLAG_FLUSH_TOKENS. r?hsivonen!

Depends on D135841

Comment 8

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove unused aTokenizer argument for nsIDTD::WillBuildModel/BuildModel. r?hsivonen!

Depends on D135842

Comment 9

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove unused nsIDTD::CanContain/IsContainer. r?hsivonen!

Depends on D135843

Comment 10

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove empty nsIContentSink::WillBuildModel/DidBuildModel implementations. r?hsivonen!

Depends on D135844

Comment 11

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove nsDTDMode::eDTDMode_unknown and unused nsDTDMode::eDTDMode_almost_standards/eDTDMode_fragment. r?hsivonen!

Depends on D135845

Comment 12

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove unused argument from nsIDTD::DidBuildModel. r?hsivonen!

Depends on D135846

Comment 13

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove nsIDTD::GetMode. r?hsivonen!

Depends on D135847

Comment 14

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove unused support for nested CParserContext. r?hsivonen!

Depends on D135848

Comment 15

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Always create scanner upfront. r?hsivonen!

Depends on D135879

Comment 16

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Make mSlidingBuffer a UniquePtr. r?hsivonen!

Depends on D135880

Comment 17

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Inline FindSuitableDTD in caller. r?hsivonen!

Depends on D135881

Comment 18

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove nsIDTD::WillBuildModel. r?hsivonen!

Depends on D135882

Comment 19

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Inline nsParser::WillTokenize in the caller. r?hsivonen!

Depends on D135883

Comment 20

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Inline nsParser::BuildModel. r?hsivonen!

Depends on D135884

Comment 21

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Inline nsParser::Tokenize. r?hsivonen!

Depends on D135885

Comment 22

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove nsITokenizer. r?hsivonen!

Depends on D135886

Comment 23

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Create nsParser directly instead of with a CID. r?hsivonen!

Comment 24

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove nsIParser::ParseFragment/Reset. r?hsivonen!

Depends on D135896

Comment 25

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Inline nsParser::CancelParsingEvents. r?hsivonen!

Depends on D135897

Comment 26

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Remove GetDTD. r?hsivonen!

Depends on D135898

Comment 27

[Peter Van der Beken [:peterv]]

Attachment: Bug 1749935 - Simplify nsParser::Initialize. r?hsivonen!

Depends on D135899

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83508ce6ee60
Mark nsIParser::WillResume(Impl) as infallible. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/1576222e280a
Remove unused PREFER_LATTER_ERROR_CODE. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/e1ee82d8e5db
Remove unused eAutoDetectResult values. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/d24f05815ce7
Remove nsIParser::GetChannel. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/4c4b6112d50d
Remove nsIParser::MarkAsNotScriptCreated. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/979083a9437e
Remove unused nsParser::SetUnusedInput. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/b41618e99f19
Remove unused NS_PARSER_FLAG_OBSERVERS_ENABLED and NS_PARSER_FLAG_FLUSH_TOKENS. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/f411808c8525
Remove unused aTokenizer argument for nsIDTD::WillBuildModel/BuildModel. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/514a753b085d
Remove unused nsIDTD::CanContain/IsContainer. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/8db8f12cab68
Remove empty nsIContentSink::WillBuildModel/DidBuildModel implementations. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/929416db4638
Remove nsDTDMode::eDTDMode_unknown and unused nsDTDMode::eDTDMode_almost_standards/eDTDMode_fragment. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/f800e03ad141
Remove unused argument from nsIDTD::DidBuildModel. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/b7abf97a3b2d
Remove nsIDTD::GetMode. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/ad1fa921196f
Remove unused support for nested CParserContext. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/60bdd2fd3b39
Always create scanner upfront. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/797d4dbb3684
Make mSlidingBuffer a UniquePtr. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/d8f937504615
Inline FindSuitableDTD in caller. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/4432977f8d88
Remove nsIDTD::WillBuildModel. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/669545ac4284
Inline nsParser::WillTokenize in the caller. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/4b3fad3ba013
Inline nsParser::BuildModel. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/e2546d0fa54e
Inline nsParser::Tokenize. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/db93847a85c4
Remove nsITokenizer. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/52b322741400
Create nsParser directly instead of with a CID. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/5c399611bc11
Remove nsIParser::ParseFragment/Reset. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/a0578d8be39e
Inline nsParser::CancelParsingEvents. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/5267cd84c969
Remove GetDTD. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/d77ccf22cd5e
Simplify nsParser::Initialize. r=hsivonen

Comment 29

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/83508ce6ee60
https://hg.mozilla.org/mozilla-central/rev/1576222e280a
https://hg.mozilla.org/mozilla-central/rev/e1ee82d8e5db
https://hg.mozilla.org/mozilla-central/rev/d24f05815ce7
https://hg.mozilla.org/mozilla-central/rev/4c4b6112d50d
https://hg.mozilla.org/mozilla-central/rev/979083a9437e
https://hg.mozilla.org/mozilla-central/rev/b41618e99f19
https://hg.mozilla.org/mozilla-central/rev/f411808c8525
https://hg.mozilla.org/mozilla-central/rev/514a753b085d
https://hg.mozilla.org/mozilla-central/rev/8db8f12cab68
https://hg.mozilla.org/mozilla-central/rev/929416db4638
https://hg.mozilla.org/mozilla-central/rev/f800e03ad141
https://hg.mozilla.org/mozilla-central/rev/b7abf97a3b2d
https://hg.mozilla.org/mozilla-central/rev/ad1fa921196f
https://hg.mozilla.org/mozilla-central/rev/60bdd2fd3b39
https://hg.mozilla.org/mozilla-central/rev/797d4dbb3684
https://hg.mozilla.org/mozilla-central/rev/d8f937504615
https://hg.mozilla.org/mozilla-central/rev/4432977f8d88
https://hg.mozilla.org/mozilla-central/rev/669545ac4284
https://hg.mozilla.org/mozilla-central/rev/4b3fad3ba013
https://hg.mozilla.org/mozilla-central/rev/e2546d0fa54e
https://hg.mozilla.org/mozilla-central/rev/db93847a85c4
https://hg.mozilla.org/mozilla-central/rev/52b322741400
https://hg.mozilla.org/mozilla-central/rev/5c399611bc11
https://hg.mozilla.org/mozilla-central/rev/a0578d8be39e
https://hg.mozilla.org/mozilla-central/rev/5267cd84c969
https://hg.mozilla.org/mozilla-central/rev/d77ccf22cd5e