Closed
Bug 1749989
Opened 3 years ago
Closed 3 years ago
Come up with a better name for FullScreen.getAutohide
Categories
(Firefox :: Toolbars and Customization, task, P3)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
104 Branch
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: aminomancer, Assigned: mkohler)
Details
Attachments
(1 file)
As indicated here, the method FullScreen.getAutohide has an unintuitive name. It's named like a getter but it returns nothing, it's only a side effect. Its only function is to set the checked state of a context menu's fullscreen autohide menuitem to reflect the state of the pref browser.fullscreen.autohide, as the menuitem toggles this pref. So, a better name would probably be FullScreen.updateAutohideMenuitem
|
||
Updated•3 years ago
|
Severity: -- → N/A
Priority: -- → P3
|
Reporter | |
Comment 1•3 years ago
|
||
Unless anyone objects to updateAutohideMenuitem I'll submit a patch when my previous revision for bug 1591040 lands
|
|
||
Comment 2•3 years ago
|
||
Sounds good to me.
|
Assignee | |
Comment 3•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → me
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4598339bb9b
Rename FullScreen.getAutohide to FullScreen.updateAutohideMenuitem r=jaws
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox104:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•