1750046 - Add comprehensive testing of the wasm i32/i64 compare-select idiom

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement)

Description

[Julian Seward [:jseward]]

Bug 1748700 shows a regression introduced by bug 1716580, which incorrectly
optimised some wasm compare-select cases. The underlying problem was
inadequate testing in the latter bug.

This bug adds comprehensive testing of compare-select for the following
cases:

  compare     in  i32 i64
  select      in  i32 i64
  compare-op  in  eq ne lt_s lt_u gt_s gt_u le_s le_u ge_s ge_u

It is verified as able to detect the regression introduced by bug 1716580.

Comment 1

[Julian Seward [:jseward]]

Attachment: Bug 1750046 - Add comprehensive testing of the wasm i32/i64 compare-select idiom. r=lth.

Bug 1748700 shows a regression introduced by bug 1716580, which incorrectly
optimised some wasm compare-select cases. The underlying problem was
inadequate testing in the latter bug.

This bug adds comprehensive testing of compare-select for the following
cases:

  compare     in  i32 i64
  select      in  i32 i64
  compare-op  in  eq ne lt_s lt_u gt_s gt_u le_s le_u ge_s ge_u

It is verified as able to detect the regression introduced by bug 1716580.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/512ae342256a
Add comprehensive testing of the wasm i32/i64 compare-select idiom.  r=lth.

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/512ae342256a