1750072 - Enable password reveal on chrome documents except about:logins

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, enhancement, P3)

Description

[Sergey Galich [:serg]]

Bug 1743046 will enable built-in reveal/conceal for password inputs.
We should remove custom implementation from about:logins.

Comment 1

[Sergey Galich [:serg]]

Attachment: double-reveal.png

Comment 2

[Ritika Mishra]

Hello Sergey Galich, I want to work upon this bug. I request you to kindly assign this bug to me.

Comment 3

[Sergey Galich [:serg]]

Hello Ritika, this bug is harder than it looks. We still haven't decided what exactly we want to do with it - remove custom implementation in about:logins or disable new password reveal icon. We will either need reveal/conceal events from the <input type=password> (there are no such events today) or we will need to opt-out from new reveal button in input fields (which is also not possible today).

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1750072 - Enable password reveal on chrome documents, including about:logins. r=sgalich

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1750072 - Allow to prevent password revealing/unrevealing. r=mtigley

The idea is that chrome code would be able to call preventDefault(),
then run whatever authentication they need to do, then setRevealPassword
again.

Comment 6

[Micah [:mtigley] (she/her)]

Attachment: Screenshot 2023-03-24 at 11.16.45 AM.png

Hmm, I'm still unable to detect the "MozWillRevealPassword" event after its registered on the input element. Emilio, do you know why that might be the case?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

I think you need to listen to it from the privileged actor. Something like this seems to work:

diff --git a/browser/components/BrowserGlue.sys.mjs b/browser/components/BrowserGlue.sys.mjs
index 5333e10313866..ef10e10fde1b6 100644
--- a/browser/components/BrowserGlue.sys.mjs
+++ b/browser/components/BrowserGlue.sys.mjs
@@ -238,6 +238,7 @@ let JSWINDOWACTORS = {
         AboutLoginsSyncOptions: { wantUntrusted: true },
         AboutLoginsUpdateLogin: { wantUntrusted: true },
         AboutLoginsExportPasswords: { wantUntrusted: true },
+        MozWillRevealPassword: {},
       },
     },
     matches: ["about:logins", "about:logins?*", "about:loginsimportreport"],
diff --git a/browser/components/aboutlogins/AboutLoginsChild.sys.mjs b/browser/components/aboutlogins/AboutLoginsChild.sys.mjs
index c02975b9afe08..b7f8e95798ca8 100644
--- a/browser/components/aboutlogins/AboutLoginsChild.sys.mjs
+++ b/browser/components/aboutlogins/AboutLoginsChild.sys.mjs
@@ -107,9 +107,17 @@ export class AboutLoginsChild extends JSWindowActorChild {
         this.#aboutLoginsUpdateLogin(event.detail);
         break;
       }
+      case "MozWillRevealPassword": {
+        this.#willRevealPassword(event);
+        break;
+      }
     }
   }
 
+  #willRevealPassword(event) {
+    dump(`MozWillRevealPassword(${event.target.outerHTML})\n`);
+  }
+
   #aboutLoginsInit() {
     this.sendAsyncMessage("AboutLogins:Subscribe");
 

Comment 8

[Micah [:mtigley] (she/her)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)

Ah makes sense! Thanks.

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: WIP: Bug 1750072 - WIP - Make reveal button tab-navigable.

Feels rather odd...

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49d0f7fb2091
Allow to prevent password revealing/unrevealing. r=mtigley

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/49d0f7fb2091

Comment 12

[Micah [:mtigley] (she/her)]

Attachment: WIP: Bug 1750072 - Remove custom reveal/conceal button on password field. r=#credential-management-reviewers

Comment 13

[BugBot [:suhaib / :marco]]

The leave-open keyword is there and there is no activity for 6 months.
:mtigley, maybe it's time to close this bug?
For more information, please visit BugBot documentation.

Comment 14

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1750072 - Allow to opt-out of password reveal using appearance: textfield. r=#layout

Much like we do for the number input spinners.

Comment 15

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1750072 - Enable password reveal on chrome documents, and opt out on about:logins for now. r=sgalich

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74da0b0c92b4
Allow to opt-out of password reveal using appearance: textfield. r=jwatt

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b5fc9bfb805
Enable password reveal on chrome documents, and opt out on about:logins for now. r=desktop-theme-reviewers,dao

Comment 18

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/74da0b0c92b4
https://hg.mozilla.org/mozilla-central/rev/9b5fc9bfb805

Comment 19

[Mathew Hodson]

Since patches landed in this bug and there are regressions against it, I think it's easier for tracking if we close this and the remaining work to remove the custom reveal password button for about:logins can be done in bug 1706886.