1750077 - Func directive does not cause header to be included with DedicatedWorkerGlobalScope

Status: RESOLVED INVALID

(Core :: DOM: Bindings (WebIDL), defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

Attachment: DedicatedWorkerGlobalScopeBinding.cpp

With the patch in:

https://phabricator.services.mozilla.com/D135928?id=527808

CanvasUtils.h does not get included in the DedicatedWorkerGlobalScopeBinding.cpp (see attached). This causes a build failure.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Andrew,
We're reviewing S2 bugs and wondering if this is still a valid S2. Since bug 1749323 has been fixed, how important is this for OffscreenCanvas work? Thank you.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

I worked around it, so feel free to be put into the backlog.

Comment 3

[Peter Van der Beken [:peterv]]

DedicatedWorkerGlobalScope uses a custom header (see https://searchfox.org/mozilla-central/rev/1f27a4022f9f1269d897526c1c892a57743e650c/dom/bindings/Bindings.conf#183-185), in which case that header needs to include whatever is needed. See item 4 in https://firefox-source-docs.mozilla.org/dom/webIdlBindings/index.html#adding-web-idl-bindings-to-a-class: "Note that using a 'headerFile' annotation is generally not recommended. If you do use it, you will need to make sure your header includes all the headers needed for your Func annotations."