Closed
Bug 1750106
Opened 3 years ago
Closed 3 years ago
Use default member initialization in nsWindow where appropriate on Windows
Categories
(Core :: Widget: Win32, task, P3)
Tracking
()
RESOLVED
FIXED
99 Branch
| Tracking | Status | |
|---|---|---|
| firefox99 | --- | fixed |
People
(Reporter: handyman, Assigned: cmartin, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file, 1 obsolete file)
We should shift nsWindow from a constructor with a long list of lines initializing member variables to using default member initialization.
| Reporter | ||
Updated•3 years ago
|
Summary: Use default member initialization in nsWindow where appropriate → Use default member initialization in nsWindow where appropriate on Windows
Updated•3 years ago
|
Severity: -- → S4
Priority: -- → P3
| Assignee | ||
Updated•3 years ago
|
Assignee: nobody → cmartin
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•3 years ago
|
||
Also, just generally bring Win32 nsWindow more in line with our coding
standards.
| Assignee | ||
Comment 2•3 years ago
|
||
Pushed by cmartin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a3a3747998b
Use default and list initialization for Win32 nsWindow r=handyman
Comment 4•3 years ago
•
|
||
Backed out for causing multiple failures nsWindow.cpp
- Backout link
- Push with failures
- Failure Log
- Failure line: Assertion failure: !mParent, at /builds/worker/checkouts/gecko/widget/windows/nsWindow.cpp:7390
- And also other failures on windows. https://treeherder.mozilla.org/logviewer?job_id=369126449&repo=autoland
Flags: needinfo?(cmartin)
Pushed by cmartin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6012e2664c8b
Use default and list initialization for Win32 nsWindow r=handyman
Comment 6•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox99:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
| Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(cmartin)
Updated•3 years ago
|
Attachment #9265000 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•