1750140 - [wpt-sync] Sync PR 32379 - Add tests for :link or :visited in :has()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32379 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32379
Details from upstream follow.

Byungwoo Lee <[e-mail]> wrote:

Add tests for :link or :visited in :has()

Added unit tests and web platform tests for :link and :visited
in :has() argument to check leaking visitedness by :has().

When we have ':has(:visited) {...}', the subject elements of the rule
are the ancestors of the visited link element.

To prevent leaking visitedness to the link's ancestors, the ':visited'
selector does not match if it is inside the ':has()' argument selector.
So if a ':has()' argument selector requires a matching ':visited', the
style rule are not applied.

In order to apply the consistent limitation to ':has()' invalidation,
ignored the ':visited' pseudo class when building pseudo type hash set
for ':has()' invalidation to prevent invalidation triggered by :visited.

Bug: 669058
Change-Id: Ibc781c213e454db24fe892d3731f4f26e578a960
Reviewed-on: https://chromium-review.googlesource.com/3386734
WPT-Export-Revision: f954b4e07415318c37e57b882e0ce23f38daab8f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f612091c23984dd5d064c9202b20fb3b57125fa

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/selectors/invalidation/location-pseudo-classes-in-has.html
CSS Selectors Invalidation: location pseudo classes in :has() argument: FAIL (Chrome: FAIL, Safari: FAIL)
/css/selectors/has-visited.html: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/eb268a1af4d4
https://hg.mozilla.org/mozilla-central/rev/e62b005a750d