1750181 - Perma Late Beta gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:658: Unified_cpp_widget_windows1.obj] Error 1 when Gecko 98 merges to Beta on 2022-02-07

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect, P2)

Description

[Norisz Fay [:noriszfay]]

Central-as-beta simulation
How to run these simulations

Failure log:

[task 2022-01-14T11:09:30.240Z] 11:09:30     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/widget/windows'
[task 2022-01-14T11:09:30.241Z] 11:09:30     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -Xclang -std=c++17 -FoUnified_cpp_widget_windows1.obj -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DCOMPILER_MSVC -DMOZ_UNICODE -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/widget/windows -I/builds/worker/workspace/obj-build/widget/windows -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/gfx/cairo/cairo/src -I/builds/worker/checkouts/gecko/layout/forms -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/style -I/builds/worker/checkouts/gecko/layout/xul -I/builds/worker/checkouts/gecko/toolkit/xre -I/builds/worker/checkouts/gecko/widget -I/builds/worker/checkouts/gecko/widget/headless -I/builds/worker/checkouts/gecko/xpcom/base -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -FI /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -fcrash-diagnostics-dir=/builds/worker/artifacts -TP -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -Oy -Werror  -Xclang -MP -Xclang -dependency-file -Xclang .deps/Unified_cpp_widget_windows1.obj.pp -Xclang -MT -Xclang Unified_cpp_widget_windows1.obj   Unified_cpp_widget_windows1.cpp
[task 2022-01-14T11:09:30.242Z] 11:09:30     INFO -  In file included from Unified_cpp_widget_windows1.cpp:119:
[task 2022-01-14T11:09:30.242Z] 11:09:30     INFO -  /builds/worker/checkouts/gecko/widget/windows/nsAppShell.cpp(537,12): error: unused variable 'wcA' [-Werror,-Wunused-variable]
[task 2022-01-14T11:09:30.242Z] 11:09:30     INFO -        ATOM wcA = RegisterClassW(&wc);
[task 2022-01-14T11:09:30.243Z] 11:09:30     INFO -             ^
[task 2022-01-14T11:09:30.243Z] 11:09:30     INFO -  1 error generated.
[task 2022-01-14T11:09:30.243Z] 11:09:30    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:658: Unified_cpp_widget_windows1.obj] Error 1
[task 2022-01-14T11:09:30.243Z] 11:09:30     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/widget/windows'
[task 2022-01-14T11:09:30.243Z] 11:09:30     INFO -  gmake[4]: *** Waiting for unfinished jobs....
[task 2022-01-14T11:09:30.243Z] 11:09:30     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/crashreporter/google-breakpad/src/processor'

Comment 1

[Christian Holler (:decoder)]

This is simply a missing [[maybe_unused]] for the variable, will make a patch on Monday.

Comment 2

[Christian Holler (:decoder)]

Attachment: Bug 1750181 - Silence warning about unused diagnostic variable. r?gsvelto

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8fb098d3602
Silence warning about unused diagnostic variable. r=gsvelto

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a8fb098d3602

Comment 5

[Iulian Moraru]

Fix verified in today's central as late beta simulation