1750214 - LoginHelper.jsm getElementById() hang when developer console open

Status: UNCONFIRMED

(DevTools :: Console, defect, P3)

Description

[simo.bot87]

Attachment: Immagine 2022-01-14 162221.png

Steps to reproduce:

Open the widget page on a Wordpress admin area with the dev console opened

Actual results:

Firefox hang, a lot of notices in the console.

È stata trasmessa una stringa vuota a getElementById() LoginHelper.jsm:1460:8

(getElementById() was called with an empty string)

both on 95.0.2 (64 bit) and 97.0b3 (64 bit)

Expected results:

Not hang.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Console' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

We know about console performance issues (and are going to look at them in the next couple months)
I also can't find the line that would be using getElementById in LoginHelper.jsm (https://searchfox.org/mozilla-release/rev/723f2b3dd4f885827602e56f3e79e7aaabe52421/toolkit/components/passwordmgr/LoginHelper.jsm#1460)

simo.bot87, is the page you're seeing this on public?
Also, does clicking on the message location (LoginHelper.jsm:1460) opens the file in the debugger/in a tab? And if so, could you paste the function the line is in?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

dimi, looking at the log it looks like you did some changes in LoginHelper.jsm, would you be aware of such issue?

Comment 4

[Dimi Lee [:dimi]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)

dimi, looking at the log it looks like you did some changes in LoginHelper.jsm, would you be aware of such issue?

We never use getElementById in LoginHelper.jsm (even in the past).
But there might be something we can try, :simo.bot87, could you help test

1. open about:config
2. set signon.generation.confidenceThreshold to -1
   and see if you can reproduce this issue? thanks!

Comment 5

[simo.bot87]

Attachment: Immagine 2022-01-28 150823.png

Comment 6

[simo.bot87]

Attachment: Immagine 2022-01-28 150856.png

Comment 7

[simo.bot87]

(In reply to Dimi Lee [ooo Jan.29 - Feb.5] from comment #4)

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)

dimi, looking at the log it looks like you did some changes in LoginHelper.jsm, would you be aware of such issue?

We never use getElementById in LoginHelper.jsm (even in the past).
But there might be something we can try, :simo.bot87, could you help test

1. open about:config
2. set signon.generation.confidenceThreshold to -1
   and see if you can reproduce this issue? thanks!

Tested with 97.0b9 (64 bit), signon.generation.confidenceThreshold` to -1
did not hang but 31500 warnings in console, see images above.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Thanks sim.bot87..
So I think element.labels uses getElementById under the hood.
If you navigate to data:text/html,<meta charset=utf8><label id="label1" for="">Label 1</label><input id=""><script>console.log(document.querySelector("input").labels)</script> and open the console, you'll see the getElementById warning message.

Could you share with us what the following expression returns in the console please, just to be sure ? document.querySelectorAll(input[id=""])

Now, I really don't know how we could get rid of such message, as it's not an error. We could try to check if element.id is not an empty string before accessing element.labels in https://searchfox.org/mozilla-release/rev/723f2b3dd4f885827602e56f3e79e7aaabe52421/toolkit/components/passwordmgr/LoginHelper.jsm#1460 , but I'm not sure about this.

I'll file a bug for having a proper warning message when using labels instead of mentioning getElementById.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

(filed Bug 1752564 for better warning message)

Comment 10

[Jennifer Montoya]

Attachment: same problem

Thanks from cyareacala1983.