1750251 - Perma Late-Beta macOS spi-nw TEST-UNEXPECTED-TIMEOUT | security/manager/ssl/tests/unit/test_cert_chains.js | Test timed out - when Gecko 98 merges to Beta on 2022-02-18

Status: VERIFIED FIXED

(Core :: Security: PSM, defect)

Description

[Sandor Molnar[:smolnar]]

Central-as-late-beta simulation

How to run these simulations

Failure log

INFO -  TEST-PASS | security/manager/ssl/tests/unit/test_cert_chains.js |  - failedCertChain should be deserialized correctly - true == true
[task 2022-01-14T13:56:54.898Z] 13:56:54     INFO -  (xpcshell/head.js) | test run_next_test 7 pending (3)
[task 2022-01-14T13:56:54.898Z] 13:56:54     INFO -  (xpcshell/head.js) | test finished (3)
[task 2022-01-14T13:56:54.899Z] 13:56:54     INFO -  (xpcshell/head.js) | test run_next_test 6 finished (2)
[task 2022-01-14T13:56:54.899Z] 13:56:54     INFO -  security/manager/ssl/tests/unit/test_cert_chains.js | Starting
[task 2022-01-14T13:56:54.899Z] 13:56:54     INFO -  (xpcshell/head.js) | test pending (2)
[task 2022-01-14T13:56:54.899Z] 13:56:54     INFO -  (xpcshell/head.js) | test run_next_test 7 finished (2)
[task 2022-01-14T13:56:54.899Z] 13:56:54     INFO -  <<<<<<<
[task 2022-01-14T13:56:54.899Z] 13:56:54     INFO -  xpcshell return code: None
[task 2022-01-14T13:56:54.899Z] 13:56:54     INFO -  security/manager/ssl/tests/unit/test_cert_chains.js | Process still running after test!
[task 2022-01-14T13:56:55.093Z] 13:56:55  WARNING -  TEST-UNEXPECTED-FAIL | Received SIGINT (control-C), so stopped run. (Use --keep-going to keep running tests after killing one with SIGINT)
[task 2022-01-14T13:56:55.094Z] 13:56:55     INFO -  Retrying tests that failed when run in parallel.
[task 2022-01-14T13:56:55.102Z] 13:56:55     INFO -  TEST-START | browser/components/urlbar/tests/unit/test_providerPlaces.js
[task 2022-01-14T13:56:56.436Z] 13:56:56  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/unit/test_providerPlaces.js | xpcshell return code: 0
[task 2022-01-14T13:56:56.436Z] 13:56:56     INFO -  TEST-INFO took 1334ms

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Is this related to bug 1748341? (Previous cenral-as-late-beta had been run on Tuesday). It's not from bug 1747320. The failure is only observed on macOS with the new socket process code.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1741425 turned on the execution of xpcshell tests with socket process. Kershaw, could you take care of the tests which fail in central-as-late-beta simulations, very likely because network.process.enabled is false for late beta and release?

Comment 4

[Kershaw Chang [:kershaw]]

(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #2)

Bug 1741425 turned on the execution of xpcshell tests with socket process. Kershaw, could you take care of the tests which fail in central-as-late-beta simulations, very likely because network.process.enabled is false for late beta and release?

I think the reason is something else. network.process.enabled should be set to true when running socket process tests.
We can disable this test for now.

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Bug 1750251 - Skip test_cert_chains.js when running socket process, r=keeler

Comment 6

[Kershaw Chang [:kershaw]]

Not sure why there are so many tests failed, but I think it's fine to not running these tests with socket process.
:ahal, do you know is there a way to not run socket process tests on late beta?
Thanks.

Comment 7

[Andrew Halberstadt [:ahal]]

In this case you could change the built-projects to ["trunk"] here:
https://searchfox.org/mozilla-central/source/taskcluster/ci/test/xpcshell.yml#48

Though this only affects xpcshell.

Once you have a patch you could run ./mach taskgraph target --diff -p taskcluster/test/params --target-kind test --fast to verify your changes do what you expect (or you could also submit to Phabricator and wait for reviewbot to comment with a diff of tasks).

Comment 8

[Kershaw Chang [:kershaw]]

Attachment: Bug 1750251 - Not run socket process tests on late beta, r=ahal

Comment 9

[Ryan VanderMeulen [:RyanVM]]

This would be nice to have on ESR too where we're running spi tests without any real need to.

Comment 10

[Kershaw Chang [:kershaw]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)

This would be nice to have on ESR too where we're running spi tests without any real need to.

Do you mean spi or spi-nw tests?
As far as I know, spi tests are about testing WebRTC code on socket process and WebRTC team is close to ship this feature. So, I think we should keep spi tests on ESR.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

We're running spi-nw xpcshell on ESR91, also spi mochitest-media. Regardless, if it's not shipping yet, we're certainly not going to be backporting that to an already-existing ESR branch.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c02e7f75b9ec
Not run socket process tests on late beta, r=ahal

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c02e7f75b9ec

Comment 14

[Andreea Pavel [:apavel]]

Verified fixed in latest beta sim: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel&revision=d9f69234466a564d2fae975017179c8feab43552&searchStr=xpcshell