1750350 - Unnecessary Show password button on about:logins when layout.form.input-type-show-password-button.enabled is active

Status: UNCONFIRMED

(Core :: Layout: Form Controls, defect)

Description

[Roman Deev]

Attachment: Снимок экрана 2022-01-15 в 13.22.12.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:97.0) Gecko/20100101 Firefox/97.0

Steps to reproduce:

1. Set layout.forms.input-type-show-password-button.enabled=true
2. Open some login in about:logins

Actual results:

Two show password buttons appear next to the password. One of them doesn't work.

Expected results:

The button should not appear on a field that cannot be edited.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Form Controls' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Jonathan Kew [:jfkthame]]

I assume a similar issue may apply to web pages that implement their own "show password" functionality with a similar icon next to the password field. Not sure exactly what we should do to address this, but at least for in-browser UI pages we should do something to clean it up before we consider shipping the show-password-button functionality by default.

Comment 3

[Santiago Fernández Núñez]

Attachment: Unhide button duplication in Fb

Comment 4

[Santiago Fernández Núñez]

As @jfkthame mentioned, I could confirm that a similar behavior happens on Fb (see attached img).