1750372 - Autoland pushlog doesn't match changelog

Status: RESOLVED FIXED

(Developer Services :: Mercurial: Pushlog, defect)

Description

[Andreea Pavel [:apavel]]

:m_kato raised this up in #sheriffs, it seems that bug 1750142 landed and shows up in autoland changelog but doesn't show up in autoland pushlog or TH

In lando, the patch has the following error:

Landing requested on Sat, January 15, 2022, 1:19 PM GMT+2, by [e-mail].

Revisions: D135980 diff 528031 ← D135981 diff 528053

Raw error output:
Unexpected error while pushing to ssh://hg.mozilla.org/integration/autoland.
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: autoland or landing worker push detected
remote: recorded push in pushlog
remote: added 2 changesets with 5 changes to 4 files
remote: error committing pushlog transaction on attempt 1; retrying
remote: error committing pushlog transaction on attempt 2; retrying
remote: error committing pushlog transaction on attempt 3; retrying
remote: 
remote: View your changes here:
remote:   https://hg.mozilla.org/integration/autoland/rev/52496c100eb04bf78411b2337c403e1d412a11a0
remote:   https://hg.mozilla.org/integration/autoland/rev/0c855935ddc40651d2dc741a046f886db91382bb
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0c855935ddc40651d2dc741a046f886db91382bb
remote: recorded changegroup in replication log in 0.061s
remote: could not complete push due to pushlog operational errors; please retry, and file a bug if the issue persists

abort: push failed on remote

We also received 2 cron task failure emails for AF-EFHyZRHKANoDn3WZIGQ and ASQxfU3bQAGCqnzV_ZoTxw around the time the patch was pushed.

Comment 1

[Connor Sheehan [:sheehan]]

This is another instance of bug 1735633, leading to the same bustage as in bug 1734717. I'll do the same thing here that I did there, silently add the changes with missing pushlog info to the preceeding push. That should un-bust mozilla-unified updating.

I was actually taking a look at the pushlog transaction code earlier this week. Might be time to make it a bit more resilient.

Comment 2

[Connor Sheehan [:sheehan]]

[[e-mail]1 .hg]$ sudo sqlite3 pushlog2.db                                                                        
SQLite version 3.7.17 2013-05-20 00:56:22
Enter ".help" for instructions
Enter SQL statements terminated with a ";"
sqlite> insert into changesets (pushid, rev, node) values (156104, 604636, '52496c100eb04bf78411b2337c403e1d412a11a0');
sqlite> insert into changesets (pushid, rev, node) values (156104, 604637, '0c855935ddc40651d2dc741a046f886db91382bb');
sqlite> 

Bookmarks on unified have updated.