1750442 - Merge generated concatenated string tables for DOM bindings

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement)

Description

[Peter Van der Beken [:peterv]]

We currently generate two giant strings (table in NamesOfInterfacesWithProtos(…), and WebIDLGlobalNameHash::sNames). There's a lot of overlap in these tables, we should just merge them, to reduce binary size.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1750442 - Merge the string table for WebIDL prototypes and the WebIDL global name hash. r?farre!

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Diff of generated binding code

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:peterv, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04a4f1c3255d
Merge the string table for WebIDL prototypes and the WebIDL global name hash. r=farre

Comment 5

[Sandor Molnar[:smolnar]]

Backed out changeset 04a4f1c3255d (bug 1750442) for causing build bustages in mozilla/dom/BindingNames.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/e4dd0a7f4834d861bf80df36860510babd3114be

Push with failures

Failure log

xpc failure log

In file included from BindingNames.cpp:2:
[task 2022-02-13T10:49:21.875Z] 10:49:21    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/BindingNames.h:1025:1: error: unknown type name 'MOZ_ALWAYS_INLINE'
[task 2022-02-13T10:49:21.875Z] 10:49:21     INFO -  MOZ_ALWAYS_INLINE const char* BindingName(BindingNamesOffset aOffset) {
[task 2022-02-13T10:49:21.875Z] 10:49:21     INFO -  ^
[task 2022-02-13T10:49:21.875Z] 10:49:21    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/dom/BindingNames.h:1026:10: error: cannot initialize return object of type 'const int *' with an rvalue of type 'const char *'
[task 2022-02-13T10:49:21.875Z] 10:49:21     INFO -    return binding_detail::sBindingNames + static_cast<size_t>(aOffset);

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4393b3efb09
Merge the string table for WebIDL prototypes and the WebIDL global name hash. r=farre

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b4393b3efb09