1750527 - Give IPC_FAIL_NO_REASON a reason and check it well

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, task, P1)

Description

[Jens Stutte [:jstutte]]

IPC_FAIL_NO_REASON should not be used and transformed into IPC_FAIL with reason.

In doing so, we should also verify if the reason really merits an IPC_FAIL given the possible fatal consequences for the calling actor.

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 1750527: Remove MOZ_CRASH_UNLESS_FUZZING and give IPC_FAIL a reason. r?#dom-storage-reviewers

Comment 2

[Jan Varga [:janv]]

I will be reviewing patches like this right after bug 1688665 which has been waiting for a review for long time.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d46bb624fbce
Remove MOZ_CRASH_UNLESS_FUZZING and give IPC_FAIL a reason. r=jesup

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d46bb624fbce

Comment 5

[Jens Stutte [:jstutte]]

Comment on attachment 9264721 [details]
Bug 1750527: Remove MOZ_CRASH_UNLESS_FUZZING and give IPC_FAIL a reason. r?#dom-storage-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Bug 1746656 shows that some users get parent browser crashes somewhat frequently.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch does mostly remove some MOZ_CRASH_UNLESS_FUZZING in favor of the already in-place IPC_FAIL (which is a kind of tested code path by our fuzzers). In most cases this will just crash the calling content process instead of crashing the parent.
• String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This has a minor conflict in ActorsParent.cpp due to bug 1754448. Can you please attach a rebased patch?

Comment 7

[Jens Stutte [:jstutte]]

Attachment: WIP: Bug 1750527: Remove MOZ_CRASH_UNLESS_FUZZING and give IPC_FAIL a reason - rebased on FIREFOX_98_0_1_RELEASE

Comment 8

[Jens Stutte [:jstutte]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

This has a minor conflict in ActorsParent.cpp due to bug 1754448. Can you please attach a rebased patch?

Done. Do we need reviewers for this?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Given that the rebase was pretty trivial, I don't think it needs another round of reviews. In general, I would say it's only really needed when the rebased patch requires more significant changes compared to the original. Thanks!

Comment 10

[Jens Stutte [:jstutte]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)

Given that the rebase was pretty trivial, I don't think it needs another round of reviews. In general, I would say it's only really needed when the rebased patch requires more significant changes compared to the original. Thanks!

Is there any outstanding action here I should take? Thanks!

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9268075 [details]
WIP: Bug 1750527: Remove MOZ_CRASH_UNLESS_FUZZING and give IPC_FAIL a reason - rebased on FIREFOX_98_0_1_RELEASE

Approved for 98.0.2, thanks.

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/cc23a50fcf60