1750596 - Save to Pocket move vendors into their own bundle

Status: RESOLVED FIXED

(Firefox :: Pocket, enhancement)

Description

[Scott [:thecount] Downe]

I think we should bundle vendors separate from the rest of our own bundled code.

This seems to reduce the overall size of the bundle(s) a bit, and also reduces the size of the diff, making the diff easier to read and scroll.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1750596 - Moving save to Pocket vendors into their own bundle.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb40a646b246
Moving save to Pocket vendors into their own bundle. r=gvn

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_pocket_main.js

• backout: https://hg.mozilla.org/integration/autoland/rev/6d3a3c8966760cd852a9cf7583554d530373e453

• push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=UkLros85SxSAkL4_AcjtWw.0&revision=bb40a646b2467de4880d771fb56e6b50a03b8595&group_state=expanded

• failure log: https://treeherder.mozilla.org/logviewer?job_id=364585658&repo=autoland&lineNumber=2767

[task 2022-01-19T04:07:33.453Z] 04:07:33     INFO - TEST-START | browser/components/pocket/test/unit/panels/browser_pocket_main.js
[task 2022-01-19T04:07:33.901Z] 04:07:33     INFO - TEST-INFO | started process screentopng
[task 2022-01-19T04:07:34.513Z] 04:07:34     INFO - TEST-INFO | screentopng: exit 0
[task 2022-01-19T04:07:34.514Z] 04:07:34     INFO - Buffered messages logged at 04:07:33
[task 2022-01-19T04:07:34.514Z] 04:07:34     INFO - Entering test bound test_clickHelper
[task 2022-01-19T04:07:34.516Z] 04:07:34     INFO - Buffered messages finished
[task 2022-01-19T04:07:34.517Z] 04:07:34     INFO - TEST-UNEXPECTED-FAIL | browser/components/pocket/test/unit/panels/browser_pocket_main.js | Uncaught exception - at resource://testing-common/sinon-7.2.7.js:3156 - Error: Trying to stub property 'sendMessage' of undefined
[task 2022-01-19T04:07:34.518Z] 04:07:34     INFO - Stack trace:
[task 2022-01-19T04:07:34.519Z] 04:07:34     INFO - throwOnFalsyObject@resource://testing-common/sinon-7.2.7.js:3156:15
[task 2022-01-19T04:07:34.520Z] 04:07:34     INFO - stub@resource://testing-common/sinon-7.2.7.js:2958:24
[task 2022-01-19T04:07:34.520Z] 04:07:34     INFO - stub@resource://testing-common/sinon-7.2.7.js:2099:33
[task 2022-01-19T04:07:34.520Z] 04:07:34     INFO - test_clickHelper@chrome://mochitests/content/browser/browser/components/pocket/test/unit/panels/browser_pocket_main.js:31:11
[task 2022-01-19T04:07:34.520Z] 04:07:34     INFO - testTask@chrome://mochitests/content/browser/browser/components/pocket/test/unit/panels/browser_pocket_main.js:10:13
[task 2022-01-19T04:07:34.520Z] 04:07:34     INFO - Tester_execTest/<@chrome://mochikit/content/browser-test.js:1130:34
[task 2022-01-19T04:07:34.521Z] 04:07:34     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1170:11
[task 2022-01-19T04:07:34.521Z] 04:07:34     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:978:14
[task 2022-01-19T04:07:34.521Z] 04:07:34     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1041:13
[task 2022-01-19T04:07:34.522Z] 04:07:34     INFO - Leaving test bound test_clickHelper
[task 2022-01-19T04:07:34.522Z] 04:07:34     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-01-19T04:07:34.523Z] 04:07:34     INFO - TEST-UNEXPECTED-FAIL | browser/components/pocket/test/unit/panels/browser_pocket_main.js | test left unexpected property on window: webpackChunksave_to_pocket_ff - 
[task 2022-01-19T04:07:34.523Z] 04:07:34     INFO - GECKO(2217) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2022-01-19T04:07:34.523Z] 04:07:34     INFO - GECKO(2217) | MEMORY STAT heapAllocated not supported in this build configuration.
[task 2022-01-19T04:07:34.524Z] 04:07:34     INFO - GECKO(2217) | MEMORY STAT | vsize 20983340MB | residentFast 1193MB
[task 2022-01-19T04:07:34.524Z] 04:07:34     INFO - TEST-OK | browser/components/pocket/test/unit/panels/browser_pocket_main.js | took 512ms

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f7a1884d8ee
Moving save to Pocket vendors into their own bundle. r=gvn

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3f7a1884d8ee