1750610 - Remove redundant template parameter from template class constructor

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P5)

Description

[Tooru Fujisawa [:arai]]

Constructor definition for template class doesn't need template parameter.

https://searchfox.org/mozilla-central/rev/72c7cef167829b6f1e24cae216fa261934c455fc/js/src/jit/InlineList.h#149

template <typename T>
class InlineForwardListIterator {
...
  explicit InlineForwardListIterator<T>(const InlineForwardList<T>* owner)

https://searchfox.org/mozilla-central/rev/72c7cef167829b6f1e24cae216fa261934c455fc/js/src/vm/Scope.h#1590-1591

template <>
class AbstractBindingIter<JSAtom> : public BaseAbstractBindingIter<JSAtom> {
...
  explicit AbstractBindingIter<JSAtom>(Scope* scope);
  explicit AbstractBindingIter<JSAtom>(JSScript* script);

c++17 allows such redundant parameter, but apparanetly c++20 disallows it
https://stackoverflow.com/questions/63513984/can-class-template-constructors-have-a-redundant-template-parameter-list-in-c2

and compiling the code with g++ with -std=c++20 throws the syntax error.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1750610 - Remove unnecessary template parameter from template class constructor declaration. r?nbp!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79ae152be505
Remove unnecessary template parameter from template class constructor declaration. r=nbp

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/79ae152be505