1750687 - Override colors specified by page with custom colors not applying when Use system colors is enabled

Status: UNCONFIRMED

(Core :: Layout, defect)

Description

[James H]

Attachment: When use system colors is enabled it overrdes all my custom selections even my grey window and orange text in the web browser in the right.

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:96.0) Gecko/20100101 Firefox/96.0

Steps to reproduce:

I changed the color settings in custom colors from "always" to "never" , with the "use system colors" button not enabled "no checkmark", and witnessed the settings screen go from white "setting clicked to 'always'", to black "setting clicked to "never".
All this happened while the "use system colors option was not toggled on.

Actual results:

Every time I apply custom colors and then click always, and then toggle the use system colors option above it, the system colors "dark theme" override the custom colors despite the fact that the settings lists the option to have the custom colors override the colors specified with the page with my selections,

Expected results:

The settings screen should not be turning white when the override colors toggle is moved to "always" with the "use system colors" toggle is off
Because when I move the override colors specified by the page toggle to "never" changes with the "use system colors" toggle off changes it to black. There is no reason that the settings screen should be turning white.
The use system colors toggle is broken in the settings when a custom color profile is selected to "always", and the use system colors toggle should not be overriding the custom colors selected in the normal web browser either.

Comment 1

[James H]

Attachment: Picture showing setting screen turning White when system color not toggled

This picture shows that the settings screen will turn white when "use system colors" is off, and my custom colors are set to "always" override

Comment 2

[James H]

Comment on attachment 9259476 [details]
Picture showing setting screen turning White when system color not toggled

The settings screen goes white when my custom colors are selected to "always override" the webpage selection

Comment 3

[James H]

Comment on attachment 9259476 [details]
Picture showing setting screen turning White when system color not toggled

The setting screen turns white despite my custom color setting toggled to "always"

Comment 4

[James H]

Attachment: Picture showing dark system color applying even when apply system color setting is not toggled, with custom colors set to never

The webpage and settings screen both go black even though the use system colors toggle is not applied. I find this strange because when the use system colors toggle is not applied when using custom colors, it forces the settings screen to go white. I would expect the setting screen to follow the override webpage colors with my custom colours, but it doesn't display in the all black like the picture here, or my custom colors, it forces it to white.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 6

[James H]

I accidentally posted the same comment a few times so let me summarize please.
1.The settings screen changes from white to black when the "use system colors" toggle is left on, but when switching the "override colors specified by the page with your selections above" is turned from "always" to "never". I don't know why the settings screen would be changing colors in this case.

2. When I have my custom colors override set to "always", the "use system colors toggle seems to override even that when it is toggled to "on", and forces my webpages to be all black. It seems to override any custom colors selected.

3. Is there any reason why the settings screen cannot be displayed in the custom override colors? And why does the settings screen default to white when the use system colors is toggled off, even though the settings screen turns dark when use systems colors is still toggled off but custom color override is set to never?

Is there some way that having the use system colors options will only apply in cases where the custom color override will not function? I suppose in this case it would be in the settings menu.

It appears that "use system colors" overrides any custom color selections, and when the system colors are disabled when the color selection is set to "never" it still seems to be applying them uniformaly as though the button had no purpose. Preferably the Custom colors should not be overriden by the use system colors toggle above it, but I don't know if this is possible.

Comment 7

[James H]

Attachment: Picture showing that dark mode is applying regardless of whether use system colors toggle is applied or not.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

The settings screen changes from white to black when the "use system colors" toggle is left on, but when switching the "override colors specified by the page with your selections above" is turned from "always" to "never". I don't know why the settings screen would be changing colors in this case.

If you use a dark theme, the settings screen is dark unless you force your own colors (in which case it becomes light because our settings dialog only configures the light colors): https://searchfox.org/mozilla-central/rev/8d108a59d067ce37671090b0b1972ee8adfb7196/widget/nsXPLookAndFeel.cpp#1147-1164

When I have my custom colors override set to "always", the "use system colors toggle seems to override even that when it is toggled to "on", and forces my webpages to be all black. It seems to override any custom colors selected.

This has always been the case, afaict.

Is there any reason why the settings screen cannot be displayed in the custom override colors? And why does the settings screen default to white when the use system colors is toggled off, even though the settings screen turns dark when use systems colors is still toggled off but custom color override is set to never?

This is because the settings screen uses system colors directly, and we don't override those with user colors as per the CSS spec.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:hiro, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[wumkbt]

I use Dark Mode on everything so I didn't expect the Settings page to turn blinding white after I unchecked "Use system colors" and set "Override colors specified by page" to "Always" -- this seems counter-intuitive and counter-productive for everyone who uses Dark Mode. The intent is to prevent a blinding white page in any situation.

I think this was fixed in one of the updates for 95 or 96, I can't remember exactly, but then this bug came back for Firefox 97.

(I'm on Windows 10 Pro, 64b)