Closed Bug 1750716 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 32430 - CSSMathInvert should serialize 1/0 expression

Categories

(Core :: DOM: CSS Object Model, task, P4)

Product:
Core
Component:
DOM: CSS Object Model
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox98 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32430 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32430
Details from upstream follow.

Seokho Song <0xdevssh@gmail.com> wrote:

CSSMathInvert should serialize 1/0 expression

According to the spec [1], the expression of 1/0 should be serialized.

However, In DetermineCategory() in css_math_expression_node.cc
evaluates kCalcOther.

Therefore, Evaluate conditionally the division by zero with
a feature flag 'Allow Infinity and NaN in CSS calc' to prevent
return nullptr in the creation of the expression tree.

[1] https://www.w3.org/TR/css-typed-om-1/#calc-serialization

Bug: 1240306
Change-Id: I3c7705665af71d47ef3140bdd5671569dc394da4

Reviewed-on: https://chromium-review.googlesource.com/3386741
WPT-Export-Revision: bcf8e07ac37138bfcf5ef7cd59a1fad481e236b4

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 22 subtests

Status Summary

Firefox

ERROR: 1

Chrome

OK : 1
PASS : 20
FAIL : 2

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)

Tests Disabled in Gecko Infrastructure

/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: ERROR)

https://hg.mozilla.org/mozilla-central/rev/66eb9b96e612

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.