1750740 - Visual artifacts on https://codepen.io/DonKarlssonSan/pen/YzradwR with accelerated canvas

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Mayank Bansal]

Attachment: bandicam 2022-01-18 18-35-53-376.mp4

enable accelerated canvas
go to https://codepen.io/DonKarlssonSan/pen/YzradwR

AR: visual artifacts on the page. See attached video for details.

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Mayank Bansal]

2022-01-18T18:47:42.159000: INFO : application_version: 98.0a1
2022-01-18T18:47:42.159000: INFO : platform_buildid: 20220114174754
2022-01-18T18:47:42.159000: INFO : platform_changeset: 3b192b0c6080c3dcf98645c0ef12a31f1c4d7bbc
2022-01-18T18:47:42.159000: INFO : platform_repository: https://hg.mozilla.org/integration/autoland
2022-01-18T18:47:42.159000: INFO : platform_version: 98.0a1
2022-01-18T18:47:51.201000: INFO : Narrowed integration regression window from [1561820d, b30500c5] (3 builds) to [1561820d, 3b192b0c] (2 builds) (~1 steps left)
2022-01-18T18:47:51.217000: DEBUG : Starting merge handling...
2022-01-18T18:47:51.217000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=3b192b0c6080c3dcf98645c0ef12a31f1c4d7bbc&full=1
2022-01-18T18:47:51.217000: DEBUG : redo: attempt 1/3
2022-01-18T18:47:51.217000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=3b192b0c6080c3dcf98645c0ef12a31f1c4d7bbc&full=1',), kwargs: {}, attempt #1
2022-01-18T18:47:51.217000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2022-01-18T18:47:53.492000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=3b192b0c6080c3dcf98645c0ef12a31f1c4d7bbc&full=1 HTTP/1.1" 200 None
2022-01-18T18:47:53.523000: DEBUG : Found commit message:
Bug 1745556 - Add support for stroked paths to path cache. r=gfx-reviewers,aosmond

Differential Revision: https://phabricator.services.mozilla.com/D135902

2022-01-18T18:47:53.523000: DEBUG : Did not find a branch, checking all integration branches
2022-01-18T18:47:53.523000: INFO : The bisection is done.
2022-01-18T18:47:53.523000: INFO : Stopped

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: Bug 1750740 - Avoid handling single-line stroked paths as generalized paths in DrawTargetWebgl. r?aosmond

It is not desirable or expedient to treat paths containing a single line as if they were general paths
for caching purposes. This is rather wasteful and can require an entire large surface for a line that
is suboptimally oriented (such as a diagonal line). This seems to be also causing unintentional visual
artifacts. For now, just detect when a path is actually a line and send it explicitly along to StrokeLine.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91860e6f7448
Avoid handling single-line stroked paths as generalized paths in DrawTargetWebgl. r=aosmond

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/91860e6f7448