Closed Bug 1750742 Opened 4 months ago Closed 3 months ago

Enable win32k lockdown by default in Nightly

Categories

(Core :: Security: Process Sandboxing, task, P1)

Unspecified
Windows
task

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: evilpie, Assigned: cmartin)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert)

Attachments

(2 files)

No description provided.
No longer blocks: win32k-lockdown
Depends on: 1750859
Assignee: nobody → cmartin
Severity: -- → S3
Priority: -- → P1
Depends on: 1751367
Depends on: 1755734

It's time to graduate Win32k lockdown from Nightly Experiments to default on
Nightly.

Pushed by cmartin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/052d3687f4f0
Enable Win32k Lockdown by default in Nightly r=bobowen

Backed out changeset 052d3687f4f0 (Bug 1750742) for causing marionette test failures.
Backout link
Push with failures
Failure Log

Flags: needinfo?(cmartin)

This also changes gen_win32k_tests.py to work on Windows.

Attachment #9265165 - Attachment description: Bug 1750742 - Enable Win32k Lockdown by default in Nightly → Bug 1750742 - Enable Win32k Lockdown by default in Nightly r=bobowen

(In reply to Bob Owen (:bobowen) from comment #4)

Try push with (hopefully) fixed enabled by default tests:
https://treeherder.mozilla.org/jobs?repo=try&revision=469b69c6bdddd8be968bfea038af1e2a6b284017

I've fixed the lint error (single quotes in gen script).

Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9ab08f172d80
p0: Fix test_win32k_enrollment.py for when win32k is enabled by default. r=tjr
https://hg.mozilla.org/integration/autoland/rev/cfc475962a9e
Enable Win32k Lockdown by default in Nightly r=bobowen
Flags: needinfo?(cmartin)
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
Regressions: 1757102

(In reply to Marian-Vasile Laza from comment #3)

Backed out changeset 052d3687f4f0 (Bug 1750742) for causing marionette test failures.
Backout link
Push with failures
Failure Log

== Change summary for alert #33418 (as of Tue, 01 Mar 2022 11:41:51 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
15% cpstartup content-process-startup windows10-64-shippable-qr e10s fission stylo webrender-sw 69.46 -> 58.83
15% cpstartup content-process-startup windows10-64-shippable-qr e10s fission stylo webrender 70.12 -> 59.92
11% cpstartup content-process-startup windows10-64-shippable-qr e10s fission stylo webrender 67.07 -> 59.42

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33418

(In reply to Alex Finder from comment #9)

For clarity was it the back-out or the re-landing that caused the improvement?

Flags: needinfo?(afinder)

(In reply to Bob Owen (:bobowen) from comment #10)

(In reply to Alex Finder from comment #9)

For clarity was it the back-out or the re-landing that caused the improvement?

Between 9ab08f172d80 and cfc475962a9e, it was revision cfc475962a9e that caused the improvement (corresponding to patch D139487 ). Upon initial post, I thought it was related to the backout, but I can't find that revision in the backout link. So I suspect it's from the re-landing. Sorry for the confusion!

Flags: needinfo?(afinder)
You need to log in before you can comment on or make changes to this bug.