1750820 - Make webgl-ipc the default configuration for mochitests

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, task, P2)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Some thoughts:

• I wrote the patch, but I don't feel that comfortable switching things. It's pretty perfect right now, where the default is always in-process and the -ipc/-gli variant is always out-of-process, so we always know what's being tested. (yay!)
• So long as we can fall back to the in-process mode, we need testing, so that falling back isn't risking further failures.
• Also, Android still isn't OOP, which makes "test the default" sort of hard to be specific about.
  • Should we try to turn it on there?
• I feel like we need to keep up the current testing regime until we unship in-process, whereas right now isn't not even really deprecated. (We're still shipping it today on Linux and Android)
• If we want to reduce testing cost for these, we should instead just reduce frequency for the configs that we don't expect to be used as often.
• I understand the desire for RelEng to more trivially have our default configuration tested by our default variant, but I don't think that should be the goal in and of itself.
• The reality is that we ship both configs still. (maybe not on mac?) We definitely support blocklisting to fallback to in-process. Think of this like testing our escape pods: We should test them unless we remove them. We probably shouldn't stop testing them while we still have them. Another way, if they're not worth testing, are they really worth supporting at all? Or should we remove what we don't test.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Android is always the exception. For fission we are running e10s (i.e. !fission) tests on linux opt/debug/asan to get us more complete coverage for that mode and linux is most similar to Android.

while we don't run every test in -gli, I was looking to clean this up:
https://treeherder.mozilla.org/jobs?repo=mozilla-central&searchStr=gli&revision=192e73e7c91313c09603efd1650931b917746bf4

It sounds like maybe we don't have any actionable work now- if so, when should we adjust the date to revisit:
https://searchfox.org/mozilla-central/source/taskcluster/ci/test/variants.yml#105

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1750820 - remove unneeded comment. r=jgilbert!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8412733be804
remove unneeded comment. r=jgilbert

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8412733be804

Comment 6

[Kelsey Gilbert [:jgilbert]]

We're not done yet!

Comment 7

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1750820 - Make webgl-ipc the default mochitest config.

Add tier-2 variant for webgl-no-ipc.

Comment 8

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1750820 - webgl.out-of-process=true by default for CI.

Comment 9

[Kelsey Gilbert [:jgilbert]]

https://treeherder.mozilla.org/jobs?repo=try&revision=a65643897c9d8b52c444d49efc318f042cdae372

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9589f2cbd6a4
webgl.out-of-process=true by default for CI. r=taskgraph-reviewers,perftest-reviewers,jmaher,fbilt

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9589f2cbd6a4