Closed Bug 1750938 Opened 2 years ago Closed 2 years ago

Disable AudioIPC on macOS until known issues are resolved

Categories

(Core :: Audio/Video: cubeb, task)

Firefox 97
All
macOS
task

Tracking

()

RESOLVED FIXED
98 Branch
Tracking Status
firefox97 blocking fixed
firefox98 --- unaffected

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(2 files, 1 obsolete file)

This backs out bug 1425788 due to regressions, but the revert is different due to bug 1748160's changes.

Attachment #9259662 - Attachment description: Bug 1750938 - Disable AudioIPC on macOS until known issues are resolved. r?#cubeb-reviewers a?pascalc → Bug 1750938 - Disable AudioIPC on macOS until known issues are resolved. r?#cubeb-reviewers

Comment on attachment 9259662 [details]
Bug 1750938 - Disable AudioIPC on macOS until known issues are resolved. r?#cubeb-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: Various audio regressions linked from bug bug 1425788
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple pref change, reverts to previous behaviour
  • String changes made/needed: No
Attachment #9259662 - Flags: approval-mozilla-beta?

As discussed in bug 1748826 comment 6 and 7, I'll update the backout patch so we can also address bug 1748826.

Attachment #9259662 - Attachment is obsolete: true
Attachment #9259662 - Flags: approval-mozilla-beta?

Comment on attachment 9260039 [details]
Bug 1750938 - Disable AudioIPC on macOS until known issues are resolved. r?#cubeb-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: Request as per previous (cancelled) approval request, but with a different backout approach.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String changes made/needed:
Attachment #9260039 - Flags: approval-mozilla-beta?

Comment on attachment 9260039 [details]
Bug 1750938 - Disable AudioIPC on macOS until known issues are resolved. r?#cubeb-reviewers

Disables audioIPC on macOS due various known regressions and reverts us back to the previous state prior to landing. Approved for 97.0b7.

Attachment #9260039 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

It seems like this only landed in 97. Can we also turn it off in 98 until the crackling is resolved?

(In reply to Jeff Muizelaar [:jrmuizel] from comment #8)

It seems like this only landed in 97. Can we also turn it off in 98 until the crackling is resolved?

Matthew wdyt?

Flags: needinfo?(kinetik)

Yeah, let's do that for now. I can reproduce bug 1749790 locally now, so hopefully this will be fixed shortly.

Flags: needinfo?(kinetik)
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56c58eceb379
Disable AudioIPC on macOS until known issues are resolved.  r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: