Disable AudioIPC on macOS until known issues are resolved
Categories
(Core :: Audio/Video: cubeb, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox97 | blocking | fixed |
firefox98 | --- | unaffected |
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
Attachments
(2 files, 1 obsolete file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
Details | Review |
This backs out bug 1425788 due to regressions, but the revert is different due to bug 1748160's changes.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
Comment on attachment 9259662 [details]
Bug 1750938 - Disable AudioIPC on macOS until known issues are resolved. r?#cubeb-reviewers
Beta/Release Uplift Approval Request
- User impact if declined: Various audio regressions linked from bug bug 1425788
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple pref change, reverts to previous behaviour
- String changes made/needed: No
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
As discussed in bug 1748826 comment 6 and 7, I'll update the backout patch so we can also address bug 1748826.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
This effectively reverts bug 1425788 and bug 1748160, and switches the audioipc-2 vendor source to https://github.com/kinetiknz/audioipc/commits/macos_v97b.
Assignee | ||
Comment 5•2 years ago
|
||
Comment on attachment 9260039 [details]
Bug 1750938 - Disable AudioIPC on macOS until known issues are resolved. r?#cubeb-reviewers
Beta/Release Uplift Approval Request
- User impact if declined: Request as per previous (cancelled) approval request, but with a different backout approach.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky):
- String changes made/needed:
Comment 6•2 years ago
|
||
Comment on attachment 9260039 [details]
Bug 1750938 - Disable AudioIPC on macOS until known issues are resolved. r?#cubeb-reviewers
Disables audioIPC on macOS due various known regressions and reverts us back to the previous state prior to landing. Approved for 97.0b7.
Comment 7•2 years ago
|
||
bugherder uplift |
Comment 8•2 years ago
|
||
It seems like this only landed in 97. Can we also turn it off in 98 until the crackling is resolved?
Comment 9•2 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #8)
It seems like this only landed in 97. Can we also turn it off in 98 until the crackling is resolved?
Matthew wdyt?
Assignee | ||
Comment 10•2 years ago
|
||
Yeah, let's do that for now. I can reproduce bug 1749790 locally now, so hopefully this will be fixed shortly.
Assignee | ||
Comment 11•2 years ago
|
||
Comment 12•2 years ago
|
||
Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/56c58eceb379 Disable AudioIPC on macOS until known issues are resolved. r=jrmuizel
Comment 13•2 years ago
|
||
bugherder |
Description
•