1750966 - update_rnp script fails with "No module named thirdroc"

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

On Linux Debian
cd mozilla/comm/thirdparty
./update_rnp.sh

results in error:
/home/user/moz/commcent/mozilla/obj-x86_64-pc-linux-gnu/_virtualenvs/common/bin/python: No module named thirdroc

I found that the following manual change to the environment prevents the error:

export PYTHONPATH=../python/thirdroc/

Should this be added to the update_rnp.sh script or do you think this needs to be fixed differently?

Comment 1

[Rob Lemley [:rjl]]

I should be able to fix that without changing PYTHONPATH. Doing so was (a while ago) problematic for Python virtualenvs. Longer term, I would like to make use of mach vendor which is designed for this sort of task.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1750966 - Set PYTHONPATH so that "thirdroc" module can be located. r=kaie

Ideally, PYTHONPATH won't need setting. This is to unblock updates to RNP 0.16.0.

Comment 3

[Rob Lemley [:rjl]]

I looked into using mach vendor. It looks like it won't work until one-repo gets going.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a1684fe02ea4
Set PYTHONPATH so that "thirdroc" module can be located. r=kaie

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 9260459 [details]
Bug 1750966 - Set PYTHONPATH so that "thirdroc" module can be located. r=kaie

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: dependency
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): no risk, no code change

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9260459 [details]
Bug 1750966 - Set PYTHONPATH so that "thirdroc" module can be located. r=kaie

[Triage Comment]
Approved for esr91

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 91.8.0:
https://hg.mozilla.org/releases/comm-esr91/rev/7ab8ebf3dacc