1751000 - Add code for setting Firefox Private Browsing as the default browser

Status: RESOLVED WONTFIX

(Firefox :: Shell Integration, enhancement, P1)

Description

[[e-mail] (:bhearsum)]

This will depend on the new AUMID and ProgIDs we'll be adding in https://bugzilla.mozilla.org/show_bug.cgi?id=1750987.

setAsDefaultUserChoice will need an update to be optionally set Private Browsing as the default browser, and use the appropriate AUMID & ProgIds when doing so. It relies on getInstallHash when doing so, which will also need an update to be able to return the Private Browsing Mode install hash. Many other things consume this function that will not want the Private Browsing Mode hash - so we'll have to be careful that it only returns it in the correct situations.

Comment 1

[[e-mail] (:bhearsum)]

This has been descoped for the current project.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: WIP: Bug 1751000: Enable setting Firefox Private Browsing as the default browser

This works, but needs some implementation improvements. Most notably, it's probably best to stop using getInstallHash and create a new method somewhere to centralize the handling of the ;Private magic string. WinTaskbar::GetAppUserModelId seemed like the obvious place, as it has other special handling for AUMID, but that seemed ugly for reasons I can't remember.

WindowsShellService is the other obvious place, but then we'd be duplicating AUMID logic from WinTaskbar. Probably need some refactoring.