Closed Bug 1751000 Opened 1 year ago Closed 1 year ago

Add code for setting Firefox Private Browsing as the default browser

Categories

(Firefox :: Shell Integration, enhancement, P1)

Desktop
Windows
enhancement

Tracking

()

RESOLVED WONTFIX

People

(Reporter: bhearsum, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidedi-pbm])

Attachments

(1 obsolete file)

This will depend on the new AUMID and ProgIDs we'll be adding in https://bugzilla.mozilla.org/show_bug.cgi?id=1750987.

setAsDefaultUserChoice will need an update to be optionally set Private Browsing as the default browser, and use the appropriate AUMID & ProgIds when doing so. It relies on getInstallHash when doing so, which will also need an update to be able to return the Private Browsing Mode install hash. Many other things consume this function that will not want the Private Browsing Mode hash - so we'll have to be careful that it only returns it in the correct situations.

No longer blocks: 1750987
Depends on: 1750987
Blocks: di-pbm

This has been descoped for the current project.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX

This works, but needs some implementation improvements. Most notably, it's probably best to stop using getInstallHash and create a new method somewhere to centralize the handling of the ;Private magic string. WinTaskbar::GetAppUserModelId seemed like the obvious place, as it has other special handling for AUMID, but that seemed ugly for reasons I can't remember.

WindowsShellService is the other obvious place, but then we'd be duplicating AUMID logic from WinTaskbar. Probably need some refactoring.

Attachment #9262886 - Attachment is obsolete: true
Component: Installer → Shell Integration
Blocks: 1750987
No longer depends on: 1750987
You need to log in before you can comment on or make changes to this bug.