1751014 - Focus indicator is not shown when the downloads panel is opened

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Simona Badau, Desktop QA]

Note

• this is a follow-up for Bug 1742530.

Affected versions

• Nightly 98.0a1, Firefox 97 Beta

Affected platforms

• Windows 10 x64, Ubuntu 20.04, macOS Big Sur 11.6

Pre-requisites:

• Ensure to have at least 2 downloads performed.

Steps to reproduce

1. Click on the Downloads panel
2. Press the Down Arrow key
3. Close the Downloads panel and open it again
4. Press the Tab key.

Expected result
In step 1 the focus indicator should be visible on the first top download from the list (as pressing the Down Arrow key focuses the second download).

In step 3, the focus indicator should be visible on the first top download as the tab cycles the button from the first row.

Actual result
In steps 1 and 3, the focus indicators are not visible.

Additional notes
This is not a regression.

Comment 1

[:Gijs (he/him)]

I think not showing a focus indicator when using the mouse is expected, but I also don't see a focus indicator when opening the panel with the keyboard. Neil, was this on your radar?

Comment 2

[Neil Deakin]

Attachment: Bug 1751014, show keyboard indicator by default when opening the download panel with the keyboard, r=mak

Comment 3

[Neil Deakin]

Couldn't figure out how the focus with the download panel works to write a test.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfdeea514460
show keyboard indicator by default when opening the download panel with the keyboard, r=mak

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dfdeea514460