Closed
Bug 1751029
Opened 4 years ago
Closed 4 years ago
Fix isContextMenu typo in openExtraAddressRowsMenu
Categories
(Thunderbird :: Message Compose Window, task)
Thunderbird
Message Compose Window
Tracking
(thunderbird_esr91 wontfix)
RESOLVED
FIXED
98 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr91 | --- | wontfix |
People
(Reporter: henry-x, Assigned: henry-x)
Details
Attachments
(1 file)
The fifth argument of openPopup is meant to be isContextMenu (https://searchfox.org/mozilla-central/rev/d4b9c457db637fde655592d9e2048939b7ab2854/dom/webidl/XULPopupElement.webidl#82). This was incorrectly set to true in openExtraAddressRowsMenu even though the popup is not a context menu (I just copied it over in bug 1721352).
I don't know of any buggy behaviour, but it should be corrected.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Comment 2•4 years ago
|
||
Not really an issue per se, so even tho this "mistake" is on 91, it's not worth uplifting.
Also the code in that section diverged quite a bit from trunk.
Good find!
status-thunderbird_esr91:
--- → wontfix
|
|
Assignee | |
Updated•4 years ago
|
Keywords: checkin-needed-tb
|
||
Updated•4 years ago
|
Target Milestone: --- → 98 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/7cba2f9bbb38
Fix isContextMenu typo in openExtraAddressRowsMenu. r=aleca
You need to log in
before you can comment on or make changes to this bug.
Description
•