1751168 - Verify if a missing VideoDecoder is a good reason to IPC_FAIL

Status: NEW

(Core :: Audio/Video: GMP, task, P3)

Description

[Jens Stutte [:jstutte]]

Follow up from D136364.

GMPVideoDecoderChild functions often check:

if (!mVideoDecoder) {
    return IPC_FAIL(this, "!mVideoDecoder");
}

although the rest of the functions is infallible. IIUC mVideoDecoder is nulled out explicitly in GMPVideoDecoderChild::RecvDecodingComplete, so returning IPC_FAIL if it is nullptr basically considers any further call to GMPVideoDecoderChild as being fatal.

Comment 1

[Jens Stutte [:jstutte]]

There are also obsolete comments on most of those functions:

// Ignore any return code. It is OK for this to fail without killing the
// process.

which can be just removed.