1751217 - Expose HDR video support to content

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

YouTube currently uses:

return window.matchMedia('(dynamic-range: high)').matches ||
        (window.screen.pixelDepth > 24 &&
         window.matchMedia('(color-gamut: p3)').matches);

Since we're only exposing HDR for video, it's a bit of a stretch for us to claim anything that would pass this test. However the draft media queries spec suggests a query, video-dynamic-range that would work well for us.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1751217 Part 1: Support media queries for dynamic-range and video-dynamic-range.

This is a stub that only matches "standard" for all platforms.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1751217 Part 4: Make macOS declare video-dynamic-range: high with new-enough OS.

Depends on D141053

Comment 4

[Brad Werth [:bradwerth]]

This will need tests, but I'll start with requesting review now.

Comment 5

[Brad Werth [:bradwerth]]

Strange. [NSScreen screens] gives me one screen, and NSBitsPerPixelFromDepth gets 24 bits from that screen. My same screen in Chrome reports 30 bits which I think is accurate. So there's something going on with how they are detecting the color depth and we may need to do something similar.

Comment 6

[Brad Werth [:bradwerth]]

Attachment: Bug 1751217 Part 3: Make HDR-capable macOS screens report 30 pixelDepth.

This matches Chrome behavior. Our video-dynamic-range media query also relies
on this value being greater than 24 in order to report "high" level support.

Depends on D141056

Comment 7

[Brad Werth [:bradwerth]]

Attachment: Bug 1751217 Part 5: Update test expectations.

Depends on D141306

Comment 8

[Brad Werth [:bradwerth]]

Attachment: Bug 1751217 Part 2: Change nsDeviceContext::GetDepth to eliminate the outparam.

This function always succeeds so there's no reason to maintain an nsresult.

Depends on D141053

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f16305c6ec83
Part 1: Support media queries for dynamic-range and video-dynamic-range. r=emilio
https://hg.mozilla.org/integration/autoland/rev/d35c5648c936
Part 2: Change nsDeviceContext::GetDepth to eliminate the outparam. r=emilio
https://hg.mozilla.org/integration/autoland/rev/81e41f7a1ee4
Part 3: Make HDR-capable macOS screens report 30 pixelDepth. r=mstange
https://hg.mozilla.org/integration/autoland/rev/785f4c5f719d
Part 4: Make macOS declare video-dynamic-range: high with new-enough OS. r=emilio
https://hg.mozilla.org/integration/autoland/rev/60a4497fd1f5
Part 5: Update test expectations. r=emilio

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33329 for changes under testing/web-platform/tests

Comment 11

[Marian-Vasile Laza]

Backed out 5 changesets (Bug 1751217) for causing wpt(Screen-pixelDepth-Screen-colorDepth001.html) and mochitest(test_media_queries.html) failures.
Backout link
Push with failures
Failure Log - wpt8
Failure Log - 4

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21e1650b12db
Part 1: Support media queries for dynamic-range and video-dynamic-range. r=emilio
https://hg.mozilla.org/integration/autoland/rev/277064a1facb
Part 2: Change nsDeviceContext::GetDepth to eliminate the outparam. r=emilio
https://hg.mozilla.org/integration/autoland/rev/bfa455b8bb1a
Part 3: Make HDR-capable macOS screens report 30 pixelDepth. r=mstange
https://hg.mozilla.org/integration/autoland/rev/50b6310935d4
Part 4: Make macOS declare video-dynamic-range: high with new-enough OS. r=emilio
https://hg.mozilla.org/integration/autoland/rev/f0a4879c9709
Part 5: Update test expectations. r=emilio

Comment 14

[Atila Butkovits]

Backed out for causing failures at dynamic-range.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/62f290f99410f345e3041e70a9c97c22c9278afc

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=A4iMALiyQOaErAWlrM1ODQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f0a4879c9709265e0b25832f02b33505563cc93d

Failure log: https://treeherder.mozilla.org/logviewer?job_id=372102858&repo=autoland&lineNumber=6689

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 16

[Brad Werth [:bradwerth]]

The test verification of Screen-pixelDepth-Screen-colorDepth001.html fails in the same way even without this patch applied, so I'm going to attempt another landing with every issue fixed but that one.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b741f7f2cbf
Part 1: Support media queries for dynamic-range and video-dynamic-range. r=emilio
https://hg.mozilla.org/integration/autoland/rev/a271c6ef730b
Part 2: Change nsDeviceContext::GetDepth to eliminate the outparam. r=emilio
https://hg.mozilla.org/integration/autoland/rev/1b57e65d4d7e
Part 3: Make HDR-capable macOS screens report 30 pixelDepth. r=mstange
https://hg.mozilla.org/integration/autoland/rev/17c23e78c904
Part 4: Make macOS declare video-dynamic-range: high with new-enough OS. r=emilio
https://hg.mozilla.org/integration/autoland/rev/38e81996feb2
Part 5: Update test expectations. r=emilio

Comment 18

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0b741f7f2cbf
https://hg.mozilla.org/mozilla-central/rev/a271c6ef730b
https://hg.mozilla.org/mozilla-central/rev/1b57e65d4d7e
https://hg.mozilla.org/mozilla-central/rev/17c23e78c904
https://hg.mozilla.org/mozilla-central/rev/38e81996feb2

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 20

[Dipika]

Hello, I am updating the MDN docs for dynamic-range and video-dynamic-range.
The issue tracking the doc updates is here: https://github.com/mdn/content/issues/14405

I would appreciate any help with a suitable example to add to the video-dynamic-range page.

Comment 21

[Brad Werth [:bradwerth]]

Attachment: video-dynamic-range-high-red.zip

(In reply to Dipika from comment #20)

I would appreciate any help with a suitable example to add to the video-dynamic-range page.

Hopefully this is suitable for MDN. The videos are from web-platform-test so they are license unencumbered.