1751270 - New message indicator (biff) not working for newsgroups in thead pane - JS Module

Status: VERIFIED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[Rachel Martin]

Attachment: biff-indicator-news-5.png

+++ This bug was initially created as a clone of Bug #1751160 +++

Using latest TB 97 beta 2 we're posting to eternal-september.test on news.eternal-september.org. The server is set to check for new messages every minute.

Observations:

• New messages are not retrieved.
• If another (local) folder is made current and then we return to the NG folder, the message is retrieved.
• The previous message in the thread is marked as new (biff star) although it was already read (see attachment).

With the C++ module, this works as long as the folder is left open until the message is received, see bug 1751160.

Log:

21:32:28.508 mailnews.nntp: C: POST NntpClient.jsm:214:20
21:32:28.553 mailnews.nntp: S: 340 Ok, recommended message-ID <sscgss$f3s$[e-mail]> NntpClient.jsm:142:20
21:32:28.865 mailnews.nntp: S: 240 Article received <sscgss$f3s$[e-mail]> NntpClient.jsm:142:20
21:32:28.920 NotAllowedError: Could not remove the file at C:\Users\jorgk\AppData\Local\Temp\nscopy-3.tmp
21:34:10.041 mailnews.nntp: C: GROUP eternal-september.test NntpClient.jsm:214:20
21:34:10.086 mailnews.nntp: S: 211 5847 1759 9259 eternal-september.test NntpClient.jsm:142:20
21:34:10.087 mailnews.nntp: C: XOVER 9258-9259 NntpClient.jsm:214:20
21:34:10.140 mailnews.nntp: S: 224 Overview information for 9258-9259 follows NntpClient.jsm:142:20
21:34:10.268 mailnews.nntp: Receiving 797 bytes of data NntpClient.jsm:149:22

You can see that the message was sent at 21:32:28.865, we waited until 21:34 and then switched between folders. A little disconcerting also the NotAllowedError.

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1751270 - Fix biff and avoid duplicate range in XOVER for nntp-js. r=mkmelin

• serverRequiresPasswordForBiff is used by nsMsgBiffManager before performBiff
• getLastMissingRange should not return keys already known

Comment 2

[Ping Chen [:rnons] (away)]

Good catch, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dbd39cc59f3f
Fix biff and avoid duplicate range in XOVER for nntp-js. r=mkmelin

Comment 4

[Rachel Martin]

BTW, this does NOT fix bug 1751160.