1751331 - Centralize build system-related things in rust build scripts

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Remove MOZ_DIST.

As mentioned in bug 1747354, the location of the dist directory is
relied to be $topobjdir/dist, so just use that consistently rather
than getting it from a separate variable for rust build scripts.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Remove unnecessary use of MOZ_SRC.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Add a mozbuild crate that exposes some build configuration items.

This will be used as a central point of authority rather than individual
crates figuring things out on their own.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Use the mozbuild crate in mozglue-static.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Use the mozbuild crate in moz_asserts.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Use the mozbuild crate in cranelift.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Use the mozbuild crate in servo.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Use the mozbuild crate in static_prefs.

Comment 9

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Use the mozbuild crate in glean.

Comment 10

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Use the mozbuild crate in xpcom.

Comment 11

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Use the mozbuild crate in gecko-profiler.

Comment 12

[Mike Hommey [:glandium]]

Attachment: Bug 1751331 - Use the mozbuild crate in nserror.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28b9aab1f174
Remove MOZ_DIST. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/7d17f75bcb38
Remove unnecessary use of MOZ_SRC. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/20faacba6db6
Add a mozbuild crate that exposes some build configuration items. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/1cd9386a3927
Use the mozbuild crate in mozglue-static. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/16d8d3f8378b
Use the mozbuild crate in moz_asserts. r=emilio
https://hg.mozilla.org/integration/autoland/rev/27df9b0ccfb1
Use the mozbuild crate in cranelift. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/f85b049d12f9
Use the mozbuild crate in servo. r=emilio
https://hg.mozilla.org/integration/autoland/rev/147faaad046f
Use the mozbuild crate in static_prefs. r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/c4081656bc53
Use the mozbuild crate in glean. r=chutten
https://hg.mozilla.org/integration/autoland/rev/76f46bd9afa1
Use the mozbuild crate in xpcom. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/14d62b8ffa5a
Use the mozbuild crate in gecko-profiler. r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/5ce212465a26
Use the mozbuild crate in nserror. r=xpcom-reviewers,nika

Comment 14

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing multiple failures. CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/db3453c5ae6e84680bbe58ac5b1cb1563f1f597d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=5ce212465a26871fbcb9d9d526589cec55895ccd&selectedTaskRun=ExlAKkF6Sh2lUtbsLQfSfQ.0

Link to failure logs :
https://treeherder.mozilla.org/logviewer?job_id=365329547&repo=autoland&lineNumber=9465
https://treeherder.mozilla.org/logviewer?job_id=365329638&repo=autoland&lineNumber=93772

Comment 15

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing bustages. CLOSED TREE

Backout link : https://hg.mozilla.org/integration/autoland/rev/7983be3e1df94f46b60ccb69ae2de10e20c308c9

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=5ce212465a26871fbcb9d9d526589cec55895ccd&selectedTaskRun=VKeKLvHfQcKVHUkiQhLHfA.0

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=365333610&repo=autoland&lineNumber=94072

Failure message: subprocess.CalledProcessError: Command '['/usr/bin/python3', '/builds/worker/workspace/sm-package/mozjs-98.0a1.0/mach', 'build']' returned non-zero exit status 2

Even after the first backout for the 2 chain-setts, the Spidermonkey fail continuued to appear:
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&fromchange=87b0596a08ab24bde54d6130f25bf64d85644954&searchStr=Linux%2Cx64%2Copt%2CSpidermonkey%2Cbuilds%2Cspidermonkey-sm-package-linux64%2Fopt%2Cpkg

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/948eb3086dae
Remove MOZ_DIST. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/6ccd458dfe29
Remove unnecessary use of MOZ_SRC. r=gfx-reviewers,lsalzman
https://hg.mozilla.org/integration/autoland/rev/6db6f0dc4731
Add a mozbuild crate that exposes some build configuration items. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/481ac23292d2
Use the mozbuild crate in mozglue-static. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/d34995355811
Use the mozbuild crate in moz_asserts. r=emilio
https://hg.mozilla.org/integration/autoland/rev/781fa5589d5f
Use the mozbuild crate in cranelift. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/73e4f996e8c3
Use the mozbuild crate in servo. r=emilio
https://hg.mozilla.org/integration/autoland/rev/4819d716eb0f
Use the mozbuild crate in static_prefs. r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/addbfb721edb
Use the mozbuild crate in glean. r=chutten
https://hg.mozilla.org/integration/autoland/rev/72a0cf96140a
Use the mozbuild crate in xpcom. r=xpcom-reviewers,nika
https://hg.mozilla.org/integration/autoland/rev/fae5ea650632
Use the mozbuild crate in gecko-profiler. r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/1074d2614f6d
Use the mozbuild crate in nserror. r=xpcom-reviewers,nika

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/948eb3086dae
https://hg.mozilla.org/mozilla-central/rev/6ccd458dfe29
https://hg.mozilla.org/mozilla-central/rev/6db6f0dc4731
https://hg.mozilla.org/mozilla-central/rev/481ac23292d2
https://hg.mozilla.org/mozilla-central/rev/d34995355811
https://hg.mozilla.org/mozilla-central/rev/781fa5589d5f
https://hg.mozilla.org/mozilla-central/rev/73e4f996e8c3
https://hg.mozilla.org/mozilla-central/rev/4819d716eb0f
https://hg.mozilla.org/mozilla-central/rev/addbfb721edb
https://hg.mozilla.org/mozilla-central/rev/72a0cf96140a
https://hg.mozilla.org/mozilla-central/rev/fae5ea650632
https://hg.mozilla.org/mozilla-central/rev/1074d2614f6d