1751360 - When restoring from minimized mode by clicking the Taskbutton, Unnecessary Titlebar(window caption bar) appears.

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect, P1)

Description

[Alice0775 White]

Steps to reproduce:

1. Disable TitleBar
2. Enter FullScreen(F11)
3. Click Minimize button of window controls so that browser window will be minimized
4. Click Taskbutton to restore the browser window
   --- Observe browser size & Titlebar

Actual results:
Unnecessary Titlebar(window caption bar) appears.
Browser does not restore to full screen mode(Bug 1751351).

Expected Results:
Titlebar(window caption bar) should not appear.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a8e8fd780528015488bece604f54cb8ffac0fd16&tochange=75ac5875c5e3d12ebb414650ccf53f48d8ee01a6

Regressed by: Bug 1742421

Chris Martin, your patch seems to cause the regression. Could you please look into this?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:alice0775, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 2

[Alice0775 White]

(In reply to Release mgmt bot [:marco/ :calixte] from comment #1)

:alice0775, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

The field cannot be filled in because access has been denied.

Comment 4

[Chris Martin [:cmartin]]

I have a patch for this incoming shortly

Comment 5

[Chris Martin [:cmartin]]

Attachment: Bug 1751360 - Backout changes made by D135606

Comment 6

[Chris Martin [:cmartin]]

Attachment: Bug 1751360 - Fix broken fullscreen behavior on Windows

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec2472db8e9a
Backout changes made by D135606 r=mhowell,handyman
https://hg.mozilla.org/integration/autoland/rev/6db8ef514517
Fix broken fullscreen behavior on Windows r=mhowell,handyman

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ec2472db8e9a
https://hg.mozilla.org/mozilla-central/rev/6db8ef514517

Comment 10

[Oana Botisan, Desktop QA]

Managed to reproduce the issue on an older version of Nightly (2022-01-21) using a x32 build on Windows 10.
Retested everything using latest Nightly 99.0a1 and Firefox 98.0b5 on the same platform. The issue is not reproducing anymore.

Comment 11

[Stephen A Pohl [:spohl]]

Chris, could you request uplift to ESR here since bug 1742421 was uplifted to ESR?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Nice catch, sorry I missed this when I approved bug 1742421 :(. We've gone ahead and pushed this to ESR now to unblock the RC builds, but it would still be good to fill in the approval request retroactively.

https://hg.mozilla.org/releases/mozilla-esr91/rev/70e5dce7b64b
https://hg.mozilla.org/releases/mozilla-esr91/rev/c17c94724a2f

Comment 14

[Chris Martin [:cmartin]]

Comment on attachment 9260966 [details]
Bug 1751360 - Fix broken fullscreen behavior on Windows

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: The bug the patch fixes is quite visible and obviously not the correct UX behavior
• User impact if declined: Fullscreen mode will continue to not function properly
• Fix Landed on Version: 98
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's not risky because it's already been on Nightly for quite a while without causing any further regressions, and it's already undergone manual testing by QA

Comment 15

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 91.7.0esr using a x32 build on Win 10 x64.