1751361 - [wdspec] Don't reset window size when tearing down a session when application doesn't support it

Status: RESOLVED FIXED

(Testing :: geckodriver, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When creating a webdriver session in the session fixture we resize the window to a default width and height.

But when cleaning up the session there is no such check and we always to try reset the window size.

This adds extra noise to the log output which would be good to get rid of.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1751361 - [marionette] Replace assertions for Firefox with Desktop.

WebDriver commands that currently assert for Firefox should
actually check for desktop because Thunderbird also supports
all of these.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1751361 - [wdspec] Don't reset window size during session cleanup if application doesn't support it.

Depends on D136574

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76875c8e527c
[marionette] Replace assertions for Firefox with Desktop. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/df8ae8598587
[wdspec] Don't reset window size during session cleanup if application doesn't support it. r=webdriver-reviewers,jdescottes

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32496 for changes under testing/web-platform/tests

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/76875c8e527c
https://hg.mozilla.org/mozilla-central/rev/df8ae8598587

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot