1751415 - firefox configure is broken with: TypeError: can only concatenate list (not "tuple") to list

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[tt_1]

Steps to reproduce:

I downloaded latest nightly sources and tried to compile them on linux-x64

Actual results:

during configure, I get this error:

0:04.76 checking for vpx >= 1.8.0... yes
0:04.76 checking MOZ_LIBVPX_CFLAGS...
0:04.77 checking MOZ_LIBVPX_LIBS... -lvpx -lm
0:04.79 checking for vpx/vpx_decoder.h... yes
0:04.79 Traceback (most recent call last):
0:04.79 File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/configure.py", line 349, in <module>
0:04.79 sys.exit(main(sys.argv))
0:04.79 File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/configure.py", line 131, in main
0:04.79 sandbox.run(os.path.join(os.path.dirname(file), "moz.configure"))
0:04.79 File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/python/mozbuild/mozbuild/configure/init.py", line 560, in run
0:04.79 func(*args)
0:04.79 File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/python/mozbuild/mozbuild/configure/init.py", line 611, in _value_for
0:04.79 return self._value_for_depends(obj)
0:04.79 File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/python/mozbuild/mozbuild/util.py", line 1061, in method_call
0:04.79 cache[args] = self.func(instance, *args)
0:04.79 File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/python/mozbuild/mozbuild/configure/init.py", line 620, in _value_for_depends
0:04.79 value = obj.result()
0:04.79 File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/python/mozbuild/mozbuild/util.py", line 1061, in method_call
0:04.79 cache[args] = self.func(instance, *args)
0:04.79 File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/python/mozbuild/mozbuild/configure/init.py", line 157, in result
0:04.79 return self._func(*resolved_args)
0:04.79 File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/python/mozbuild/mozbuild/configure/init.py", line 1294, in wrapped
0:04.79 return new_func(*args, **kwargs)
0:04.79 File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/build/moz.configure/compile-checks.configure", line 136, in flags
0:04.79 return base_flags + extra_flags
0:04.79 TypeError: can only concatenate list (not "tuple") to list
Error running mach:

['configure']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file configure| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Process executed with non-0 exit code 1: ['/var/tmp/portage/www-client/firefox-98.0/work/firefox_build/_virtualenvs/build/bin/python', '/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/configure.py']

File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/python/mozbuild/mozbuild/build_commands.py", line 254, in configure
return driver.configure(
File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/python/mozbuild/mozbuild/controller/building.py", line 1677, in configure
status = self._run_command_in_objdir(
File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/python/mozbuild/mozbuild/base.py", line 857, in _run_command_in_objdir
return self.run_process(cwd=self.topobjdir, **args)
File "/var/tmp/portage/www-client/firefox-98.0/work/firefox-98.0/python/mach/mach/mixin/process.py", line 180, in run_process
raise Exception(

Expected results:

the configure script should have passed through, as it did just a few days ago.

Comment 1

[tt_1]

I'm very bad at reading python errors, but this part:

build/moz.configure/compile-checks.configure", line 136, in flags
return base_flags + extra_flags
TypeError: can only concatenate list (not "tuple") to list

leads me to believe it was broken recently in bug1750671, and here with D136204

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1751415 - Fixup after bug 1750671.

extra_flags is not necessarily a list, originally.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17042c909350
Fixup after bug 1750671. r=firefox-build-system-reviewers,mhentges

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/17042c909350