Improve type-safety and clean up for image frame and html canvas frame
Categories
(Core :: Layout: Images, Video, and HTML Frames, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox98 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
Details in upcoming patches.
|
Assignee | |
Comment 1•2 years ago
|
||
The method is equivalent to GetContentRectRelativeToSelf().
|
|
Assignee | |
Comment 2•2 years ago
|
||
The old code operates in the CSS pixel coordinate, so we should use the type
system to express that. With this patch, nsImageControlFrame, nsImageFrame, and
nsImageMap now have no usage of nsIntPoint.
Depends on D136646
|
|
Assignee | |
Comment 3•2 years ago
|
||
The method is equivalent to GetContentRectRelativeToSelf().
Depends on D136647
|
|
Assignee | |
Comment 4•2 years ago
|
||
In general, we don't need to store used border and padding in a derived frame
class, nsIFrame::GetLogicalUsedBorderAndPadding() already provides the data.
While auditing the consumer of mBorderPadding, I realize that
nsHTMLCanvasFrame's fragmentation never works because
nsCSSFrameConstructor::CreateContinuingFrame() never creates its continuation,
and nsHTMLCanvasFrame::Reflow() never returns an incomplete reflow status to its
parent.
This patch removes the code that pretended to handle fragmentation to avoid any
confusion. Luckily, with layout.display-list.improve-fragmentation enabled by
default, we can still print <canvas> without data loss.
Depends on D136648
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/28e882f6e630 Part 1 - Remove nsImageFrame::GetInnerArea(). r=emilio https://hg.mozilla.org/integration/autoland/rev/e360e9830929 Part 2 - Use CSSIntPoint instead of nsIntPoint in image event handling code. r=emilio https://hg.mozilla.org/integration/autoland/rev/11035bf5e573 Part 3 - Remove nsHTMLCanvasFrame::GetInnerArea(). r=emilio https://hg.mozilla.org/integration/autoland/rev/7b6739a30266 Part 4 - Delete nsHTMLCanvasFrame::mBorderPadding and unused code for handling fragmentation. r=emilio
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/28e882f6e630
https://hg.mozilla.org/mozilla-central/rev/e360e9830929
https://hg.mozilla.org/mozilla-central/rev/11035bf5e573
https://hg.mozilla.org/mozilla-central/rev/7b6739a30266
Description
•