1751516 - activeAddons is missing entries

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P1)

Description

[Rob Wu [:robwu]]

The activeAddons field of the addons entry in the telemetry environment is supposed to list all active add-ons.

The current implementation looks up "extension" and "service" add-ons (this has been the case since the inception of the logic in bug 1122050, it's unclear why the list is restricted to these).
The "service" doesn't exist any more (since bug 1388902), so effectively this only returns the "extension" subset of add-ons. This list is not complete: the full list of active addon types should be included too (except for "theme" because is already covered by the theme field).

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1751516 - Correct entries in _getActiveAddons

The "service" type is obsolete, so it has been removed, and the test was
updated to remove the references to "service" / "social".

Comment 2

[Rob Wu [:robwu]]

Attachment: data-review-request-activeAddons.md

The activeAddons field in the telemetry environment has already existed for the past 7 years (since bug bug 1122050). It was meant to record all relevant add-ons, but due to the implementation only active extensions are now being recorded. The implementation is being fixed to also record other non-extension add-ons for completeness.

Comment 3

[Rob Wu [:robwu]]

Bugzilla ate my flags...

Comment 4

[Chris H-C :chutten]

Comment on attachment 9260422 [details]
data-review-request-activeAddons.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, The Add-ons Team is responsible, and specifically Rob Wu knows about this collection now.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2afc19a73fd1
Correct entries in _getActiveAddons r=mixedpuppy

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2afc19a73fd1