Closed Bug 1751681 Opened 2 years ago Closed 1 year ago

Add Serializable to FS interfaces

Categories

(Core :: DOM: File, task, P2)

Product:
Core
Component:
DOM: File
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- wontfix
firefox110 --- fixed

People

(Reporter: janv, Assigned: jjalkanen)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Bug 1751681 - Add Serializable to OPFS interfaces. r=#dom-storage-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1751681: Connect up de-serialization of OPFS handles to IPC actors r=#dom-storage-reviewers,nika,asuth
48 bytes, text/x-phabricator-request
Details | Review
Bug 1751681 - Cleanup FileSystemHandle serialization/deserialization; r=#dom-storage
48 bytes, text/x-phabricator-request
Details | Review

The initial WebIDL bindings for OPFS (bug 1750730) didn't include the Serializable attribute. We should add it rather soon because the actual architecture might depend on that.

Jari, do you want to try this ?

Flags: needinfo?(jjalkanen)

Let's try this.

Assignee: nobody → jjalkanen
Flags: needinfo?(jjalkanen)
Attachment #9261880 - Attachment description: Bug 1751681 - Add Serializable to FileSystemSyncAccessHandle. r=#dom-storage-reviewers → Bug 1751681 - Add Serializable to OPFS interfaces. r=#dom-storage-reviewers
Component: Storage: StorageManager → DOM: File
Summary: Add Serializable to OPFS interfaces → Add Serializable to FS interfaces
Attachment #9281220 - Attachment description: Bug 1751681: Connect up de-serialization of OPFS handles to IPC actors r=#dom-storage-reviewers,nika → Bug 1751681: Connect up de-serialization of OPFS handles to IPC actors r=#dom-storage-reviewers,nika,asuth
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/autoland/rev/94ae55217008
Add Serializable to OPFS interfaces. r=dom-storage-reviewers,jari,asuth

Backed out 5 changesets (Bug 1751681, Bug 1789270, Bug 1772540) for causing GTest failures.
Backout link
Push with failures <--> GTest-1proc
Failure Log

Flags: needinfo?(jjalkanen)
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aaaedc242622
Add Serializable to OPFS interfaces. r=dom-storage-reviewers,janv,jari,asuth

https://hg.mozilla.org/mozilla-central/rev/aaaedc242622

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
Regressions: 1789611

The regression seems related to be related to the graphics stack and is unlikely to be regressed by this feature.

Flags: needinfo?(jjalkanen)
No longer regressions: 1789611
Regressions: 1790207
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---
Duplicate of this bug: 1797096
Attachment #9303461 - Attachment is obsolete: true

This patch also cleanups the StorageManager public interface a bit.

Depends on D149264

Keywords: leave-open
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8fcc0a58ee5d
Connect up de-serialization of OPFS handles to IPC actors r=nika,dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/298997a4d898
Cleanup FileSystemHandle serialization/deserialization; r=dom-storage-reviewers,jesup

https://hg.mozilla.org/mozilla-central/rev/8fcc0a58ee5d
https://hg.mozilla.org/mozilla-central/rev/298997a4d898

Status: REOPENED → RESOLVED
Closed: 2 years ago → 1 year ago
status-firefox110: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: