1751681 - Add Serializable to FS interfaces

Status: RESOLVED FIXED

(Core :: DOM: File, task, P2)

Description

[Jan Varga [:janv]]

The initial WebIDL bindings for OPFS (bug 1750730) didn't include the Serializable attribute. We should add it rather soon because the actual architecture might depend on that.

Comment 1

[Jan Varga [:janv]]

Jari, do you want to try this ?

Comment 2

[Jari Jalkanen]

Let's try this.

Comment 3

[Jari Jalkanen]

Attachment: Bug 1751681 - Add Serializable to OPFS interfaces. r=#dom-storage-reviewers

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1751681: Connect up de-serialization of OPFS handles to IPC actors r=#dom-storage-reviewers,nika,asuth

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94ae55217008
Add Serializable to OPFS interfaces. r=dom-storage-reviewers,jari,asuth

Comment 6

[Marian-Vasile Laza]

Backed out 5 changesets (Bug 1751681, Bug 1789270, Bug 1772540) for causing GTest failures.
Backout link
Push with failures <--> GTest-1proc
Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaaedc242622
Add Serializable to OPFS interfaces. r=dom-storage-reviewers,janv,jari,asuth

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/aaaedc242622

Comment 9

[Jari Jalkanen]

The regression seems related to be related to the graphics stack and is unlikely to be regressed by this feature.

Comment 11

[Jan Varga [:janv]]

Attachment: Bug 1751681: Connect up de-serialization of OPFS handles to IPC actors r=#dom-storage-reviewers,nika,asuth

Comment 12

[Jan Varga [:janv]]

Attachment: Bug 1751681 - Cleanup FileSystemHandle serialization/deserialization; r=#dom-storage

This patch also cleanups the StorageManager public interface a bit.

Depends on D149264

Comment 13

[Jan Varga [:janv]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8f3fd98acf36dc48128edbb577da7834fa33535e

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fcc0a58ee5d
Connect up de-serialization of OPFS handles to IPC actors r=nika,dom-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/298997a4d898
Cleanup FileSystemHandle serialization/deserialization; r=dom-storage-reviewers,jesup

Comment 15

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8fcc0a58ee5d
https://hg.mozilla.org/mozilla-central/rev/298997a4d898