1751693 - Add telemetry probe for measuring glyph rasterization time

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Bas Schouten (:bas.schouten)]

Markus has seen profiles where this is significant. It would be good to add some probes to measure this. This also brings Glean telemetry to rust code.

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1751693: Add telemetry probe to measure glyph rasterization time and the required plumbing for WR. r=jrmuizel

Comment 2

[Markus Stange [:mstange]]

(In reply to Bas Schouten (:bas.schouten) from comment #0)

Markus has seen profiles where this is significant.

Example: https://share.firefox.dev/364Nv1I

Comment 3

[Bas Schouten (:bas.schouten)]

Attachment: Data review

Comment 4

[Chris H-C :chutten]

Comment on attachment 9269124 [details]
Data review

PRELIMINARY NOTES:
(Next time remove the header with all the exclamation points)
Also, please confirm that you, Bas, will be responsible for this non-expiring collection. (A mailing list is a good thing to have keeping an eye on things, but it's opaque. An individual is necessary)

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :Bas is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a067384b1c0
Add telemetry probe to measure glyph rasterization time and the required plumbing for WR. r=nical

Comment 6

[Marian-Vasile Laza]

Backed out changeset 6a067384b1c0 (Bug 1751693) for causing wr bustages on Cargo.toml.
Backout link
Push with failures
Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb60e3e761d2
Add telemetry probe to measure glyph rasterization time and the required plumbing for WR. r=nical

Comment 8

[Sandor Molnar[:smolnar]]

Backed out changeset fb60e3e761d2 (bug 1751693) for causing wrench bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/a57cff54ee54c3c95c61bfa120ca2e818498a6db

Push with failures

Failure log

Comment 9

[Nicolas Silva [:nical]]

Attachment: Bug 1751693 - Update wrench's chrono dependency. r=#gfx-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/935d91efef6d
Update wrench's chrono dependency. r=gfx-reviewers,jrmuizel

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/935d91efef6d

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/395f906e2904
Add telemetry probe to measure glyph rasterization time and the required plumbing for WR. r=jrmuizel,nical

Comment 13

[Bas Schouten (:bas.schouten)]

This is going to fail again, because of more wrench weirdness. Sadly I can't back it out.

Comment 14

[Cristian Tuns]

Backed out as requested by Bas on element #build.

• Backout link

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50a4c8c382b7
Add telemetry probe to measure glyph rasterization time and the required plumbing for WR. r=jrmuizel,nical

Comment 16

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1751693 - Followup: Address missed review comment by glandium. r=glandium

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/811a63c3b270
Followup: Address missed review comment by glandium. r=glandium DONTBUILD

Comment 18

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/50a4c8c382b7
https://hg.mozilla.org/mozilla-central/rev/811a63c3b270