Add a linter for jar.mn files
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement)
Tracking
(Not tracked)
People
(Reporter: calixte, Unassigned, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=python])
It'd be nice to check that files in jar.mn files are really present: it'd avoid to be backed out because of useless missing file:
https://hg.mozilla.org/projects/pine/rev/5ae7a6f1ab15baecacd7db2994a773319aed0f70#l5.13
Reporter | ||
Updated•3 years ago
|
Comment 1•3 years ago
|
||
how to do it:
https://firefox-source-docs.mozilla.org/code-quality/lint/create.html
https://searchfox.org/mozilla-central/source/tools/lint/trojan-source/__init__.py
could be use as source of inspiration
Hi,
I'm Sayan, a computer science student.
I'm new here in mozilla, eager to contribute.
Please let me fix this bug.
Comment 3•3 years ago
|
||
Sure, please give a try :)
Comment 4•3 years ago
|
||
Is someone working on this now?
Can I take over?
Comment 5•3 years ago
•
|
||
yeah, please go ahead
Comment 6•3 years ago
|
||
thank you.
can you provide a more detailed explanation on what exactly I should be doing?
Reporter | ||
Comment 7•3 years ago
•
|
||
The above patch has been backed out because the file browser/components/companion/content/companionHiddenWindow.xhtml
does not existing.
The description of jar manifest files can be found here:
- https://firefox-source-docs.mozilla.org/build/buildsystem/jar-manifests.html
- https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/jar.py
The goal of this checker is to check that the files mentioned in the manifest are correctly present in the tree.
Comment 8•3 years ago
|
||
You said the above patch has been backed out - does that mean that I should not be working on this patch?
Reporter | ||
Comment 9•3 years ago
|
||
The patch has been backed out because one of the file mentioned in the jar.mn wasn't in the tree and I'd like to avoid that in the future.
The above patch is just an example.
Comment 10•3 years ago
|
||
Okay, working on it, thank you.
Where should the file location of this checker be in the tree?
Updated•3 years ago
|
Description
•