GetAppPath() fails without no /ua option

RESOLVED WORKSFORME

Status

SeaMonkey
Installer
RESOLVED WORKSFORME
16 years ago
9 years ago

People

(Reporter: Curt Patrick (gone), Assigned: dveditz)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
In trying to borrow some code for another purpose I discovered that else block
of code which gets invoked when no UserAgent was given on the command-line does
not work correctly.  I started to fix this (I'll attach the patch) but
discovered two things:

1) This code section originally was copied from the function that gets the path
to the uninstall logfile.  If we make the fix the way I planned in this section
I'm concerned that it might be possible to end up using the uninstall logfile
from one version (determined by the Key= setting in uninstall.ini) and be
setting the path here to a different version here (determined by looking up the
CurrentVersion in the Windows registry).  This needs further consideration
before applying this patch.

2) It is almost impossible for the user hit this code.  GetAppPath() is
currently only called when the command-line option /ss or /hs is used.  This
will almost certainly only be the case when the command-line is constructed by
an installer, in which case the /ua option will most certainly also be used.

So, since the likelihood of hitting problem is very small and some more thought
is needed I'm just creating this bug so the problem doesn't get lost.  I'd not
worry about this at all except that I fear someone may need to call GetAppPath()
for some other purpose in the future in a case where it may be more likely to
have a user just double-clicking on the uninstaller.  Then this bug could become
important.
(Reporter)

Comment 1

16 years ago
Created attachment 103282 [details] [diff] [review]
Partial fix (See Comment #1)
Product: Browser → Seamonkey

Updated

12 years ago
QA Contact: bugzilla → general
Seamonkey and Firefox are using a new NSIS based installer. resolving this old bug, please reopen if you still get this with the new installer
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.