Closed Bug 1751723 Opened 2 years ago Closed 2 years ago

In some setups we incorrectly switch to dark mode, with freedesktop appearance = 0 and a dark theme

Categories

(Core :: Widget: Gtk, defect)

defect

Tracking

()

VERIFIED FIXED
98 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox96 --- unaffected
firefox97 --- unaffected
firefox98 --- verified

People

(Reporter: emilio, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

As reported on Matrix.

This was needed before bug 1751432 but isn't anymore, and can cause
issues. If the system GTK theme is dark we should arguably not switch to
light in that case.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a7e6edd4c37
Fix ComputeColorSchemeSetting to stop assuming 0 == Light. r=stransky
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch

Set release status flags based on info from the regressing bug 1751432

Has Regression Range: --- → yes

Verified in the most recent Nightly and Thunderbird Daily on Fedora 35 Workstation, Gnome desktop with the Adwaita-dark application theme and the apps system theme enabled.

Name Firefox
Version 98.0a1
Build ID 20220125100058

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: