1751742 - Enable stacking context display item reuse in Nightly

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement, P2)

Description

[Miko Mynttinen]

This patch enables the first part of the simplified retained display lists.

Comment 1

[Miko Mynttinen]

If there are problems related to this change, the code can be disabled by setting pref layout.display-list.retain.sc to false.

Comment 2

[Miko Mynttinen]

Attachment: Bug 1751742 - Enable stacking context display item reuse in Nightly r=mstange

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2ba5de58a9f
Enable stacking context display item reuse in Nightly r=mstange

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c2ba5de58a9f

Comment 5

[Alex Finder]

== Change summary for alert #33089 (as of Wed, 26 Jan 2022 11:53:42 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
513%	facebook-nav.friends LastVisualChange	linux1804-64-shippable-qr	cold fission webrender	946.67 -> 5,800.00
510%	facebook-nav.friends LastVisualChange	macosx1015-64-shippable-qr	cold fission webrender	955.00 -> 5,828.33
382%	facebook-nav.friends ContentfulSpeedIndex	linux1804-64-shippable-qr	cold fission webrender	302.00 -> 1,455.08
153%	facebook-nav.friends ContentfulSpeedIndex	macosx1015-64-shippable-qr	cold fission webrender	347.92 -> 880.75
14%	facebook-nav.groups ContentfulSpeedIndex	linux1804-64-shippable-qr	cold fission webrender	720.04 -> 818.25
13%	linkedin ContentfulSpeedIndex	macosx1015-64-shippable-qr	fission warm webrender	1,178.75 -> 1,335.58
13%	linkedin ContentfulSpeedIndex	linux1804-64-shippable-qr	fission warm webrender	1,259.88 -> 1,424.83
13%	reddit fcp	linux1804-64-shippable-qr	fission warm webrender	306.25 -> 346.21
12%	reddit fnbpaint	linux1804-64-shippable-qr	fission warm webrender	320.42 -> 359.42
12%	reddit FirstVisualChange	linux1804-64-shippable-qr	fission warm webrender	285.88 -> 320.00
...	...	...	...	...
5%	yahoo-mail loadtime	linux1804-64-shippable-qr	fission warm webrender	606.88 -> 634.71
4%	yahoo-mail dcf	linux1804-64-shippable-qr	fission warm webrender	610.83 -> 637.71
4%	amazon-search LastVisualChange	android-hw-g5-7-0-arm7-shippable-qr	warm webrender	4,227.92 -> 4,412.83
3%	youtube SpeedIndex	android-hw-g5-7-0-arm7-shippable-qr	warm webrender	1,382.67 -> 1,423.08
2%	youtube PerceptualSpeedIndex	android-hw-g5-7-0-arm7-shippable-qr	warm webrender	943.79 -> 966.25

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
52%	pinterest LastVisualChange	linux1804-64-shippable-qr	fission warm webrender	4,596.67 -> 2,200.00
46%	pinterest LastVisualChange	macosx1015-64-shippable-qr	fission warm webrender	4,283.33 -> 2,293.33
20%	netflix FirstVisualChange	linux1804-64-shippable-qr	fission warm webrender	200.00 -> 160.00
13%	twitter ContentfulSpeedIndex	windows10-64-shippable-qr	fission warm webrender	978.92 -> 850.42
13%	twitter SpeedIndex	windows10-64-shippable-qr	fission warm webrender	993.92 -> 865.33
...	...	...	...	...
2%	netflix LastVisualChange	windows10-64-shippable-qr	fission warm webrender	1,508.29 -> 1,471.92

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33089

Comment 6

[Alex Finder]

== Change summary for alert #33136 (as of Fri, 28 Jan 2022 07:21:22 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
20%	displaylist_mutate	windows10-64-shippable-qr	e10s fission stylo webrender	2,451.52 -> 2,939.17
19%	displaylist_mutate	linux1804-64-shippable-qr	e10s fission stylo webrender	2,495.37 -> 2,973.43
19%	displaylist_mutate	windows10-64-shippable-qr	e10s fission stylo webrender-sw	2,468.70 -> 2,933.54
18%	displaylist_mutate	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	2,318.40 -> 2,744.48
18%	displaylist_mutate	linux1804-64-shippable-qr	e10s fission stylo webrender	2,523.90 -> 2,975.28
17%	displaylist_mutate	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,760.82 -> 2,067.85
16%	displaylist_mutate	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	1,799.70 -> 2,088.98

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
7%	tart	windows10-64-shippable-qr	e10s fission stylo webrender-sw	2.68 -> 2.49
6%	tart	windows10-64-shippable-qr	e10s fission stylo webrender	2.78 -> 2.60
2%	tart	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	2.07 -> 2.03

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33136