1751778 - Allow re-evaluating input device when GraphDriver is not AudioCallbackDriver

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, enhancement, P1)

Description

[C.M.Chang[:chunmin]]

Per bug 1749281 commet 4, the AudioInputProcessing::mRequestedInputChannelCount will be used before it's set in AudioInputProcessing::SetRequestedInputChannelCount via MediaEngineWebRTCMicrophoneSource::ApplySettings. It's better to call SetRequestedInputChannelCount, which will call MediaTrackGraphImpl::ReevaluateInputDevice(), before mRequestedInputChannelCount is used. However, when SetRequestedInputChannelCount is called, the MediaTrackGraph may be driven by SystemClockDriver so we need to allow running MediaTrackGraphImpl::ReevaluateInputDevice() during SystemClockDriver time, or not to call it when SystemClockDriver time

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1751778 - Allow re-evaluateing input device before starting audio

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1751778 - Move declaration to if statement

Depends on D136795

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f67a050016f
Allow re-evaluateing input device before starting audio r=padenot
https://hg.mozilla.org/integration/autoland/rev/0fc51ca0327f
Move declaration to if statement r=padenot

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5f67a050016f
https://hg.mozilla.org/mozilla-central/rev/0fc51ca0327f