Closed Bug 1751778 Opened 2 years ago Closed 2 years ago

Allow re-evaluating input device when GraphDriver is not AudioCallbackDriver

Categories

(Core :: Audio/Video: MediaStreamGraph, enhancement, P1)

Product:
Core
Component:
Audio/Video: MediaStreamGraph
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
99 Branch
Tracking Flags:
Tracking Status
firefox99 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

Details

Attachments

(2 files)

Bug 1751778 - Allow re-evaluateing input device before starting audio
48 bytes, text/x-phabricator-request
Details | Review
Bug 1751778 - Move declaration to if statement
48 bytes, text/x-phabricator-request
Details | Review

Per bug 1749281 commet 4, the AudioInputProcessing::mRequestedInputChannelCount will be used before it's set in AudioInputProcessing::SetRequestedInputChannelCount via MediaEngineWebRTCMicrophoneSource::ApplySettings. It's better to call SetRequestedInputChannelCount, which will call MediaTrackGraphImpl::ReevaluateInputDevice(), before mRequestedInputChannelCount is used. However, when SetRequestedInputChannelCount is called, the MediaTrackGraph may be driven by SystemClockDriver so we need to allow running MediaTrackGraphImpl::ReevaluateInputDevice() during SystemClockDriver time, or not to call it when SystemClockDriver time

Blocks: 1749281
Summary: Allow reevaluating input device when SystemClockDriver is running → Allow re-evaluating input device when SystemClockDriver is running

Depends on D136795

Blocks: 1751963
No longer blocks: 1749281
Attachment #9260482 - Attachment description: Bug 1751778 - Allow re-evaluateing input device during SystemDriver time → Bug 1751778 - Allow re-evaluateing input device before starting AudioCallbackDriver
Attachment #9260483 - Attachment description: Bug 1751778 - Init AudioCallbackDriver in if statement → Bug 1751778 - Move declaration to if statement
Summary: Allow re-evaluating input device when SystemClockDriver is running → Allow re-evaluating input device when GraphDriver is not AudioCallbackDriver
Attachment #9260482 - Attachment description: Bug 1751778 - Allow re-evaluateing input device before starting AudioCallbackDriver → Bug 1751778 - Allow re-evaluateing input device before starting audio
Pushed by cchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f67a050016f
Allow re-evaluateing input device before starting audio r=padenot
https://hg.mozilla.org/integration/autoland/rev/0fc51ca0327f
Move declaration to if statement r=padenot

https://hg.mozilla.org/mozilla-central/rev/5f67a050016f
https://hg.mozilla.org/mozilla-central/rev/0fc51ca0327f

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox99: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.