Closed Bug 1751895 Opened 2 years ago Closed 2 years ago

Calling window.close() from an action popup script does not fully close the popup.

Categories

(Thunderbird :: Add-Ons: Extensions API, defect)

defect

Tracking

(thunderbird_esr91 wontfix)

RESOLVED FIXED
99 Branch
Tracking Status
thunderbird_esr91 --- wontfix

People

(Reporter: TbSync, Assigned: TbSync)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Due to this bug, the popup is still "open" and another call to openPopup() fails.

Summary: Calling window.close() from a action popup script does not fully close the window. → Calling window.close() from an action popup script does not fully close the popup.

Here
https://searchfox.org/comm-central/rev/44a1db4edca6679b6b711ecba7b640fe58baef04/mail/components/extensions/ExtensionPopups.jsm#623

this.shown should be true, but it is not. Calling hidePopup() propperly closes the popup. Hm...

Assignee: nobody → john
Status: NEW → ASSIGNED
Attachment #9260938 - Attachment description: Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan → WIP: Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan
Attachment #9260938 - Attachment description: WIP: Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan → Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan
Attachment #9260938 - Attachment description: Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan → WIP: Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan
Attachment #9260938 - Attachment description: WIP: Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan → Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan
Attachment #9260938 - Attachment description: Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan → WIP: Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan
Attachment #9260938 - Attachment description: WIP: Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan → Bug 1751895 - Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan

Status for 91?

Target Milestone: --- → 99 Branch

This should go on c-c only, due to the massively changed tests.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/e3f6b8d1968e
Correctly close action popups and implement missing _execute_compose_action and _execute_message_display_action for the menus API. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: